Upstream support for WebKit shared timer toggling.

Upstream support for WebKit shared timer toggling.

This is part of Chrome for Android upstreaming.

These changes are used on the Java app side to suspend webkit timers in all
renderers when activity is paused and resume timers when activity is resumed.

This reduces javascript execution when the app is in the background, causing
lesser CPU and network usage. It doesn't stop javascript altogether because if
the page JS is constantly running without relying on timers/events then it
continues to run (but that is quite rare).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147438

[Yaron, 2012-06-28 15:57:00]

lgtm in principle but you should get a core content/chrome reviewer

https://chromiumcodereview.appspot.com/10690023/diff/2001/chrome/common/rende...
File chrome/common/render_messages.h (right):

https://chromiumcodereview.appspot.com/10690023/diff/2001/chrome/common/rende...
chrome/common/render_messages.h:636: // Tells the renderer to suspend/resume the
webkit timers.
I think this should probably go with javascirpt messages arond L350

[Philippe, 2012-06-28 16:46:46]

Thanks Yaron. I'm adding the appropriate reviewers for the other parts of the
tree.

[Philippe, 2012-07-04 10:04:27]

Ping :)

[Jay Civelli, 2012-07-09 17:04:46]

lgtm

[Yaron, 2012-07-10 05:49:30]

On 2012/07/09 17:04:46, Jay Civelli wrote:
> lgtm

note you should ask specific owners to look at certain files (e.g. jcivelli:
content/test, avi: content/, etc)

[Philippe, 2012-07-11 17:21:14]

On 2012/07/10 05:49:30, Yaron wrote:
> On 2012/07/09 17:04:46, Jay Civelli wrote:
> > lgtm
> 
> note you should ask specific owners to look at certain files (e.g. jcivelli:
> content/test, avi: content/, etc)

I'm adding jam@ for content/.

Thanks

[jam, 2012-07-11 20:59:27]

it's odd that you have the IPC message and the dispatching code in the chrome
repo, but not the code that sends the IPC. the code that sends/receives the IPC
should be in the same repo. so maybe you just want to have the RenderThread
function in content, and the other code can stay in your repo

http://codereview.chromium.org/10690023/diff/6001/content/public/renderer/ren...
File content/public/renderer/render_thread.h (right):

http://codereview.chromium.org/10690023/diff/6001/content/public/renderer/ren...
content/public/renderer/render_thread.h:113: virtual void
ToggleWebKitSharedTimer(bool suspend) = 0;
nit: move above the platform specific block

[Philippe, 2012-07-17 15:45:24]

We had a recent internal refactoring moving the ProcessUtils class (including
the code that sends the IPC) to the Chromium side.

Thanks to this refactoring I can now upstream some parts of ProcessUtils.

http://codereview.chromium.org/10690023/diff/6001/content/public/renderer/ren...
File content/public/renderer/render_thread.h (right):

http://codereview.chromium.org/10690023/diff/6001/content/public/renderer/ren...
content/public/renderer/render_thread.h:113: virtual void
ToggleWebKitSharedTimer(bool suspend) = 0;
On 2012/07/11 20:59:27, John Abd-El-Malek wrote:
> nit: move above the platform specific block

Done.

[Philippe, 2012-07-17 15:55:00]

On 2012/07/17 15:45:24, Philippe wrote:
> We had a recent internal refactoring moving the ProcessUtils class (including
> the code that sends the IPC) to the Chromium side.
> 
> Thanks to this refactoring I can now upstream some parts of ProcessUtils.
> 
>
http://codereview.chromium.org/10690023/diff/6001/content/public/renderer/ren...
> File content/public/renderer/render_thread.h (right):
> 
>
http://codereview.chromium.org/10690023/diff/6001/content/public/renderer/ren...
> content/public/renderer/render_thread.h:113: virtual void
> ToggleWebKitSharedTimer(bool suspend) = 0;
> On 2012/07/11 20:59:27, John Abd-El-Malek wrote:
> > nit: move above the platform specific block
> 
> Done.

To be clearer, I already upstreamed some parts of ProcessUtils in the last patch
set which means that you can take another look :)

[jam, 2012-07-19 08:01:01]

lgtm

[Philippe, 2012-07-19 08:50:39]

Thanks John.

[commit-bot: I haz the power, 2012-07-19 08:50:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10690023/16002

[commit-bot: I haz the power, 2012-07-19 09:06:15]

Try job failure for 10690023-16002 (retry) on win for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-07-19 09:33:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10690023/31001

[commit-bot: I haz the power, 2012-07-19 10:14:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10690023/32003

[commit-bot: I haz the power, 2012-07-19 10:48:29]

Try job failure for 10690023-32003 (retry) on linux_rel for step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-07-19 12:39:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10690023/32003

[commit-bot: I haz the power, 2012-07-19 14:03:53]

Change committed as 147438