Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10690019: Remove ANDROID_APK_TEST_TARGET (Closed)

Created:
8 years, 5 months ago by nilesh
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Remove ANDROID_APK_TEST_TARGET It is always true now and can be replaced with OS_ANDROID. BUG=125059 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M base/test/test_suite.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_support_android.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nilesh
8 years, 5 months ago (2012-06-28 00:22:37 UTC) #1
nilesh
8 years, 5 months ago (2012-06-28 00:22:51 UTC) #2
Mark Mentovai
LGTM
8 years, 5 months ago (2012-06-28 14:18:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10690019/1
8 years, 5 months ago (2012-06-28 18:42:42 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-06-28 19:36:26 UTC) #5
Change committed as 144775

Powered by Google App Engine
This is Rietveld 408576698