chrome/test/data/extensions/bad/Extensions/hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh/manifest.json - Issue 10690016: Check zero-length icon files during extension validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/bad/Extensions/hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh/manifest.json

Issue 10690016: Check zero-length icon files during extension validation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Included extension #3 Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension_file_util.cc ('K') | « chrome/test/data/extensions/bad/Extensions/hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh/icon.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/bad/Extensions/hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh/manifest.json

diff --git a/chrome/test/data/extensions/bad/Extensions/hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh/manifest.json b/chrome/test/data/extensions/bad/Extensions/hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh/manifest.json

new file mode 100644

index 0000000000000000000000000000000000000000..f9324150b1eb3e4b62dec44d82d7926b79b49f54

--- /dev/null

+++ b/chrome/test/data/extensions/bad/Extensions/hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh/manifest.json

@@ -0,0 +1,8 @@

+ "name": "My extension with a zero-length page action icon",

+ "version": "1.0",

+ "page_action": {

+ "default_icon": "icon.png"

+ },

+ "manifest_version": 2