Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: src/api.cc

Issue 10689191: Fix off-by-one-pointer error in an ASSERT inside DeferredHandles::Iterate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6496 matching lines...) Expand 10 before | Expand all | Expand 10 after
6507 6507
6508 DeferredHandles::~DeferredHandles() { 6508 DeferredHandles::~DeferredHandles() {
6509 impl_->DestroyDeferredHandles(this); 6509 impl_->DestroyDeferredHandles(this);
6510 } 6510 }
6511 6511
6512 6512
6513 void DeferredHandles::Iterate(ObjectVisitor* v) { 6513 void DeferredHandles::Iterate(ObjectVisitor* v) {
6514 ASSERT(!blocks_.is_empty()); 6514 ASSERT(!blocks_.is_empty());
6515 6515
6516 ASSERT((first_block_limit_ >= blocks_.first()) && 6516 ASSERT((first_block_limit_ >= blocks_.first()) &&
6517 (first_block_limit_ < &(blocks_.first())[kHandleBlockSize])); 6517 (first_block_limit_ <= &(blocks_.first())[kHandleBlockSize]));
6518 6518
6519 v->VisitPointers(blocks_.first(), first_block_limit_); 6519 v->VisitPointers(blocks_.first(), first_block_limit_);
6520 6520
6521 for (int i = 1; i < blocks_.length(); i++) { 6521 for (int i = 1; i < blocks_.length(); i++) {
6522 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 6522 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
6523 } 6523 }
6524 } 6524 }
6525 6525
6526 6526
6527 } } // namespace v8::internal 6527 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698