Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 10689190: Block printing through JS when printing is disabled by policy or pref (Closed)

Created:
8 years, 5 months ago by bartfab (slow)
Modified:
8 years, 5 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews
Visibility:
Public.

Description

Block printing through JS when printing is disabled by policy or pref This CL ensures that when the PrintingEnabled policy or the corresponding printing.enabled pref is set, the JS window.print() call is completely ignored. Previously, it was bringing up a print preview dialog. BUG=107709 TEST=Policy and pref both successfully block JS printing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148622

Patch Set 1 #

Patch Set 2 : Rebased now that the printing.* prefs are moving to the profile. #

Patch Set 3 : Meh. The printing code changed under me. Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M chrome/browser/printing/print_view_manager.h View 1 2 5 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 2 6 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bartfab (slow)
Hi Albert Could you please review this CL? It builds directly on the functionality you ...
8 years, 5 months ago (2012-07-13 09:56:22 UTC) #1
Albert Bodenhamer
lgtm
8 years, 5 months ago (2012-07-13 16:27:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/10689190/1
8 years, 5 months ago (2012-07-17 08:16:44 UTC) #3
commit-bot: I haz the power
Try job failure for 10689190-1 (retry) on mac_rel for steps "browser_tests, unit_tests". It's a second ...
8 years, 5 months ago (2012-07-17 09:22:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/10689190/15001
8 years, 5 months ago (2012-07-26 12:00:49 UTC) #5
commit-bot: I haz the power
Try job failure for 10689190-15001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-26 12:18:34 UTC) #6
bartfab (slow)
Albert, I feel this CL has changed enough that it would be good if you ...
8 years, 5 months ago (2012-07-26 16:16:56 UTC) #7
Albert Bodenhamer
still lgtm
8 years, 5 months ago (2012-07-26 19:00:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/10689190/28002
8 years, 5 months ago (2012-07-26 19:06:58 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 21:03:41 UTC) #10
Change committed as 148622

Powered by Google App Engine
This is Rietveld 408576698