Rolling libjingle to 158:159

Rolling libjingle to 159.

TEST=unit tests, webrtc pytest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146709

[Ronghua Wu (Left Chromium), 2012-07-13 00:37:34]

Although I'm still wait for one CL from libjingle and a new version of libyuv.
But I don't expect further changes to this cl expect pumping the DEPS version.

So please help review this cl.

[Sergey Ulanov, 2012-07-13 01:22:48]

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
File content/renderer/media/mock_media_stream_dependency_factory.cc (right):

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_media_stream_dependency_factory.cc:180: //
TODO(perkj): Implement type().
Many other methods in this class are marked as NOTIMPLEMETED()? Is this method
exceptional in any way so we need TODO for it but not for other methods?

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_media_stream_dependency_factory.cc:182: return
kOffer;
add NOTIMPLEMENTED().

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
File content/renderer/media/mock_peer_connection_impl.cc (right):

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_peer_connection_impl.cc:173: const
SessionDescriptionOptions& options) {}
move } to the next line.

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_peer_connection_impl.cc:188: IceOptions options) {
return false; }
move return to a separate line. This style is used only in headers for function
that fit in one line.

http://codereview.chromium.org/10689180/diff/8002/remoting/client/plugin/pepp...
File remoting/client/plugin/pepper_port_allocator.cc (right):

http://codereview.chromium.org/10689180/diff/8002/remoting/client/plugin/pepp...
remoting/client/plugin/pepper_port_allocator.cc:344: this, component,
ice_username_fragment, ice_password,
do we need to pass content_name to PepperPortAllocatorSession() so that it can
pass it to HttpPortAllocatorSessionBase?

http://codereview.chromium.org/10689180/diff/8002/remoting/protocol/libjingle...
File remoting/protocol/libjingle_transport_factory.cc (right):

http://codereview.chromium.org/10689180/diff/8002/remoting/protocol/libjingle...
remoting/protocol/libjingle_transport_factory.cc:139: channel_.reset(new
cricket::P2PTransportChannel("",
nit: move this to the next line

[tommi (sloooow) - chröme, 2012-07-13 11:08:04]

lgtm with sergey's comments addressed.

[Ronghua Wu (Left Chromium), 2012-07-13 18:26:34]

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
File content/renderer/media/mock_media_stream_dependency_factory.cc (right):

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_media_stream_dependency_factory.cc:180: //
TODO(perkj): Implement type().
On 2012/07/13 01:22:48, sergeyu wrote:
> Many other methods in this class are marked as NOTIMPLEMETED()? Is this method
> exceptional in any way so we need TODO for it but not for other methods?

Not sure about the history, those may not needed by the tests. But the one just
added should be implemented for the testing.

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
File content/renderer/media/mock_peer_connection_impl.cc (right):

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_peer_connection_impl.cc:173: const
SessionDescriptionOptions& options) {}
On 2012/07/13 01:22:48, sergeyu wrote:
> move } to the next line.

Done.

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_peer_connection_impl.cc:188: IceOptions options) {
return false; }
On 2012/07/13 01:22:48, sergeyu wrote:
> move return to a separate line. This style is used only in headers for
function
> that fit in one line.

Done.

http://codereview.chromium.org/10689180/diff/8002/remoting/client/plugin/pepp...
File remoting/client/plugin/pepper_port_allocator.cc (right):

http://codereview.chromium.org/10689180/diff/8002/remoting/client/plugin/pepp...
remoting/client/plugin/pepper_port_allocator.cc:344: this, component,
ice_username_fragment, ice_password,
On 2012/07/13 01:22:48, sergeyu wrote:
> do we need to pass content_name to PepperPortAllocatorSession() so that it can
> pass it to HttpPortAllocatorSessionBase?

Done.

http://codereview.chromium.org/10689180/diff/8002/remoting/protocol/libjingle...
File remoting/protocol/libjingle_transport_factory.cc (right):

http://codereview.chromium.org/10689180/diff/8002/remoting/protocol/libjingle...
remoting/protocol/libjingle_transport_factory.cc:139: channel_.reset(new
cricket::P2PTransportChannel("",
On 2012/07/13 01:22:48, sergeyu wrote:
> nit: move this to the next line

Done.

[Sergey Ulanov, 2012-07-13 21:06:24]

LGTM, but see my comments

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
File content/renderer/media/mock_media_stream_dependency_factory.cc (right):

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_media_stream_dependency_factory.cc:180: //
TODO(perkj): Implement type().
On 2012/07/13 18:26:35, Ronghua Wu wrote:
> On 2012/07/13 01:22:48, sergeyu wrote:
> > Many other methods in this class are marked as NOTIMPLEMETED()? Is this
method
> > exceptional in any way so we need TODO for it but not for other methods?
> 
> Not sure about the history, those may not needed by the tests. But the one
just
> added should be implemented for the testing.

Ok, maybe need to open a bug for this?

http://codereview.chromium.org/10689180/diff/12003/content/renderer/p2p/p2p_t...
File content/renderer/p2p/p2p_transport_impl.cc (right):

http://codereview.chromium.org/10689180/diff/12003/content/renderer/p2p/p2p_t...
content/renderer/p2p/p2p_transport_impl.cc:79: channel_.reset(new
cricket::P2PTransportChannel("",
move the new parameter to the next line.

http://codereview.chromium.org/10689180/diff/12003/third_party/libjingle/READ...
File third_party/libjingle/README.chromium (right):

http://codereview.chromium.org/10689180/diff/12003/third_party/libjingle/READ...
third_party/libjingle/README.chromium:4: Version: unknown
maybe just remove this line? It's useless. Revision is enough to specify the
version that we us.

[Ronghua Wu (Left Chromium), 2012-07-14 00:06:40]

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
File content/renderer/media/mock_media_stream_dependency_factory.cc (right):

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_media_stream_dependency_factory.cc:180: //
TODO(perkj): Implement type().
On 2012/07/13 21:06:24, sergeyu wrote:
> On 2012/07/13 18:26:35, Ronghua Wu wrote:
> > On 2012/07/13 01:22:48, sergeyu wrote:
> > > Many other methods in this class are marked as NOTIMPLEMETED()? Is this
> method
> > > exceptional in any way so we need TODO for it but not for other methods?
> > 
> > Not sure about the history, those may not needed by the tests. But the one
> just
> > added should be implemented for the testing.
> 
> Ok, maybe need to open a bug for this?

Created crbug/137318 for Per.

http://codereview.chromium.org/10689180/diff/8002/content/renderer/media/mock...
content/renderer/media/mock_media_stream_dependency_factory.cc:182: return
kOffer;
On 2012/07/13 01:22:48, sergeyu wrote:
> add NOTIMPLEMENTED().

NOTIMPLEMENTED is already added in the last patch.

http://codereview.chromium.org/10689180/diff/12003/content/renderer/p2p/p2p_t...
File content/renderer/p2p/p2p_transport_impl.cc (right):

http://codereview.chromium.org/10689180/diff/12003/content/renderer/p2p/p2p_t...
content/renderer/p2p/p2p_transport_impl.cc:79: channel_.reset(new
cricket::P2PTransportChannel("",
On 2012/07/13 21:06:24, sergeyu wrote:
> move the new parameter to the next line.

Done.

[commit-bot: I haz the power, 2012-07-14 00:34:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/10689180/26007

[commit-bot: I haz the power, 2012-07-14 02:08:57]

Change committed as 146709