Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: chrome/browser/chromeos/system_settings_provider.h

Issue 10689175: Refactored code for timezone settings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added missing comment. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/system_settings_provider.h
diff --git a/chrome/browser/chromeos/system_settings_provider.h b/chrome/browser/chromeos/system_settings_provider.h
index 2e5b3fe1ad13bea2d033e796f481374c9cf72951..24b304116fa776f94e8826a40f36f87ec1da0260 100644
--- a/chrome/browser/chromeos/system_settings_provider.h
+++ b/chrome/browser/chromeos/system_settings_provider.h
@@ -6,17 +6,14 @@
#define CHROME_BROWSER_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_
#include <string>
-#include <vector>
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
-#include "base/string16.h"
#include "chrome/browser/chromeos/cros_settings_provider.h"
#include "chrome/browser/chromeos/system/timezone_settings.h"
#include "third_party/icu/public/i18n/unicode/timezone.h"
namespace base {
-class ListValue;
class Value;
}
@@ -38,35 +35,11 @@ class SystemSettingsProvider : public CrosSettingsProvider,
// TimezoneSettings::Observer implementation.
virtual void TimezoneChanged(const icu::TimeZone& timezone) OVERRIDE;
- // Creates the map of timezones used by the options page.
- base::ListValue* GetTimezoneList();
-
private:
// CrosSettingsProvider implementation.
virtual void DoSet(const std::string& path,
const base::Value& in_value) OVERRIDE;
- // Gets timezone name.
- static string16 GetTimezoneName(const icu::TimeZone& timezone);
-
- // Gets timezone ID which is also used as timezone pref value.
- static string16 GetTimezoneID(const icu::TimeZone& timezone);
-
- // Gets timezone object from its id.
- const icu::TimeZone* GetTimezone(const string16& timezone_id);
-
- // Gets a timezone id from a timezone in |timezones_| that has the same
- // rule of given |timezone|.
- // One timezone could have multiple timezones,
- // e.g.
- // US/Pacific == America/Los_Angeles
- // We should always use the known timezone id when passing back as
- // pref values.
- string16 GetKnownTimezoneID(const icu::TimeZone& timezone) const;
-
- // Timezones.
- std::vector<icu::TimeZone*> timezones_;
-
scoped_ptr<base::Value> timezone_value_;
DISALLOW_COPY_AND_ASSIGN(SystemSettingsProvider);
« no previous file with comments | « chrome/browser/chromeos/system/timezone_settings.cc ('k') | chrome/browser/chromeos/system_settings_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698