Refactored code for timezone settings.

chrome/browser/ui/webui/options2/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options2/browser_options_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
+#include "base/i18n/rtl.h"
 #include "base/memory/singleton.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
+#include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "base/value_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/auto_launch_trial.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_page_zoom.h"
 #include "chrome/browser/custom_home_pages_table_model.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/instant/instant_controller.h"
 #include "chrome/browser/net/url_fixer_upper.h"
@@ skipping 47 matching lines @@
 #include "grit/theme_resources.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if !defined(OS_CHROMEOS)
 #include "chrome/browser/printing/cloud_print/cloud_print_setup_handler.h"
 #include "chrome/browser/ui/webui/options2/advanced_options_utils.h"
 #endif
 
 #if defined(OS_CHROMEOS)
+#include "base/lazy_instance.h"
+#include "base/synchronization/lock.h"
 #include "chrome/browser/chromeos/accessibility/accessibility_util.h"
-#include "chrome/browser/chromeos/cros_settings.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/options/take_photo_dialog.h"
-#include "chrome/browser/chromeos/system_settings_provider.h"
+#include "chrome/browser/chromeos/system/timezone_settings.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "ui/gfx/image/image_skia.h"
+#include "unicode/calendar.h"
+#include "unicode/timezone.h"
+#include "unicode/ures.h"
 #endif  // defined(OS_CHROMEOS)
 
 #if defined(OS_WIN)
 #include "chrome/installer/util/auto_launch_util.h"
 #endif  // defined(OS_WIN)
 
 #if defined(TOOLKIT_GTK)
 #include "chrome/browser/ui/gtk/gtk_theme_service.h"
 #endif  // defined(TOOLKIT_GTK)
 
 using content::BrowserContext;
 using content::BrowserThread;
 using content::DownloadManager;
 using content::OpenURLParams;
 using content::Referrer;
 using content::UserMetricsAction;
 
+#if defined(OS_CHROMEOS)
+namespace {
+
+struct UResClose {
+  inline void operator() (UResourceBundle* b) const {
+    ures_close(b);
+  }
+};
+
+static base::LazyInstance<base::Lock>::Leaky
+    g_timezone_bundle_lock = LAZY_INSTANCE_INITIALIZER;
+
+string16 GetExemplarCity(const icu::TimeZone& zone) {
+  // TODO(jungshik): After upgrading to ICU 4.6, use U_ICUDATA_ZONE
+  static const char* zone_bundle_name = NULL;
+
+  // These will be leaked at the end.
+  static UResourceBundle *zone_bundle = NULL;
+  static UResourceBundle *zone_strings = NULL;
+
+  UErrorCode status = U_ZERO_ERROR;
+  {
+    base::AutoLock lock(g_timezone_bundle_lock.Get());
+    if (zone_bundle == NULL)
+      zone_bundle = ures_open(zone_bundle_name, uloc_getDefault(), &status);
+
+    if (zone_strings == NULL)
+      zone_strings = ures_getByKey(zone_bundle, "zone_strings", NULL, &status);
+  }
+
+  icu::UnicodeString zone_id;
+  zone.getID(zone_id);
+  std::string zone_id_str;
+  zone_id.toUTF8String(zone_id_str);
+
+  // resource keys for timezones use ':' in place of '/'.

[Joao da Silva, 2012/07/12 18:34:09]

Nit: start sentence in uppercase

[pneubeck2, 2012/07/13 10:31:39]

Done.

+  ReplaceSubstringsAfterOffset(&zone_id_str, 0, "/", ":");
+  scoped_ptr_malloc<UResourceBundle, UResClose> zone_item(
+      ures_getByKey(zone_strings, zone_id_str.c_str(), NULL, &status));
+  icu::UnicodeString city;
+  if (!U_FAILURE(status)) {
+    city = icu::ures_getUnicodeStringByKey(zone_item.get(), "ec", &status);
+    if (U_SUCCESS(status))
+      return string16(city.getBuffer(), city.length());
+  }
+
+  // Fallback case in case of failure.
+  ReplaceSubstringsAfterOffset(&zone_id_str, 0, ":", "/");
+  // Take the last component of a timezone id (e.g. 'Baz' in 'Foo/Bar/Baz').
+  // Depending on timezones, keeping all but the 1st component
+  // (e.g. Bar/Baz) may be better, but our current list does not have
+  // any timezone for which that's the case.
+  std::string::size_type slash_pos = zone_id_str.rfind('/');
+  if (slash_pos != std::string::npos && slash_pos < zone_id_str.size())
+    zone_id_str.erase(0, slash_pos + 1);
+  // zone id has '_' in place of ' '.
+  ReplaceSubstringsAfterOffset(&zone_id_str, 0, "_", " ");
+  return ASCIIToUTF16(zone_id_str);
+}
+
+// Gets the given timezone's name for visualization.
+string16 GetTimezoneName(
+    const icu::TimeZone& timezone) {

[Joao da Silva, 2012/07/12 18:34:09]

No need to break the previous line?

[pneubeck2, 2012/07/13 10:31:39]

Done.

+  // Instead of using the raw_offset, use the offset in effect now.
+  // For instance, US Pacific Time, the offset shown will be -7 in summer
+  // while it'll be -8 in winter.
+  int raw_offset, dst_offset;
+  UDate now = icu::Calendar::getNow();
+  UErrorCode status = U_ZERO_ERROR;
+  timezone.getOffset(now, false, raw_offset, dst_offset, status);
+  DCHECK(U_SUCCESS(status));
+  int offset = raw_offset + dst_offset;
+  // offset is in msec.
+  int minute_offset = std::abs(offset) / 60000;
+  int hour_offset = minute_offset / 60;
+  int min_remainder = minute_offset % 60;
+  // Some timezones have a non-integral hour offset. So, we need to
+  // use hh:mm form.
+  std::string  offset_str = base::StringPrintf(offset >= 0 ?
+      "UTC+%d:%02d" : "UTC-%d:%02d", hour_offset, min_remainder);
+
+  // TODO(jungshik): When coming up with a better list of timezones, we also
+  // have to come up with better 'display' names. One possibility is to list
+  // multiple cities (e.g. "Los Angeles, Vancouver .." in the order of
+  // the population of a country the city belongs to.).
+  // We can also think of using LONG_GENERIC or LOCATION once we upgrade
+  // to ICU 4.6.
+  // In the meantime, we use "LONG" name with "Exemplar City" to distinguish
+  // multiple timezones with the same "LONG" name but with different
+  // rules (e.g. US Mountain Time in Denver vs Phoenix).
+  icu::UnicodeString name;
+  timezone.getDisplayName(dst_offset != 0, icu::TimeZone::LONG, name);
+  string16 result(l10n_util::GetStringFUTF16(
+      IDS_OPTIONS_SETTINGS_TIMEZONE_DISPLAY_TEMPLATE, ASCIIToUTF16(offset_str),
+      string16(name.getBuffer(), name.length()), GetExemplarCity(timezone)));
+  base::i18n::AdjustStringForLocaleDirection(&result);
+  return result;
+}
+
+// Creates a list of pairs of each timezone's ID and name.
+ListValue* GetTimezoneList() {
+  const std::vector<icu::TimeZone*> &timezones =
+      chromeos::system::TimezoneSettings::GetInstance()->GetTimezoneList();
+  ListValue* timezoneList = new ListValue();
+  for (std::vector<icu::TimeZone*>::const_iterator iter = timezones.begin();
+       iter != timezones.end(); ++iter) {
+    const icu::TimeZone* timezone = *iter;
+    ListValue* option = new ListValue();
+    option->Append(Value::CreateStringValue(
+        chromeos::system::TimezoneSettings::GetTimezoneID(*timezone)));
+    option->Append(Value::CreateStringValue(GetTimezoneName(*timezone)));
+    timezoneList->Append(option);
+  }
+  return timezoneList;
+}
+
+} // namespace anonymous

[Joao da Silva, 2012/07/12 18:34:09]

Two spaces before the comment, and just "namespace":

}  // namespace

[pneubeck2, 2012/07/13 10:31:39]

Done.

+#endif  // defined(OS_CHROMEOS)
+
 namespace options2 {
 
 BrowserOptionsHandler::BrowserOptionsHandler()
     : template_url_service_(NULL),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_ptr_factory_for_file_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_ptr_factory_for_ui_(this)) {
   multiprofile_ = ProfileManager::IsMultipleProfilesEnabled();
 #if !defined(OS_MACOSX)
   default_browser_worker_ = new ShellIntegration::DefaultBrowserWorker(this);
 #endif
@@ skipping 259 matching lines @@
       "languageSectionLabel",
       l10n_util::GetStringFUTF16(
           IDS_OPTIONS_ADVANCED_LANGUAGE_LABEL,
           l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME)));
 
 #if defined(OS_CHROMEOS)
   values->SetString("cloudPrintLearnMoreURL", chrome::kCloudPrintLearnMoreURL);
 
   // TODO(pastarmovj): replace this with a call to the CrosSettings list
   // handling functionality to come.
-  values->Set("timezoneList",
-      static_cast<chromeos::SystemSettingsProvider*>(
-          chromeos::CrosSettings::Get()->GetProvider(
-              chromeos::kSystemTimezone))->GetTimezoneList());
+  values->Set("timezoneList", GetTimezoneList());
 #endif
 #if defined(OS_MACOSX)
   values->SetString("macPasswordsWarning",
       l10n_util::GetStringUTF16(IDS_OPTIONS_PASSWORDS_MAC_WARNING));
   values->SetBoolean("multiple_profiles",
       g_browser_process->profile_manager()->GetNumberOfProfiles() > 1);
 #endif
 
   if (multiprofile_)
     values->Set("profilesInfo", GetProfilesInfoList().release());
@@ skipping 1041 matching lines @@
 }
 
 void BrowserOptionsHandler::SetupSSLConfigSettings() {
   base::FundamentalValue checked(rev_checking_enabled_.GetValue());
   base::FundamentalValue disabled(rev_checking_enabled_.IsManaged());
   web_ui()->CallJavascriptFunction(
       "BrowserOptions.setCheckRevocationCheckboxState", checked, disabled);
 }
 
 }  // namespace options2