chrome/browser/ui/webui/options2/chromeos/timezone_options_util.h - Issue 10689175: Refactored code for timezone settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/options2/chromeos/timezone_options_util.h

Issue 10689175: Refactored code for timezone settings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addressed comments. Moved chromeos specific code from browser_options_handler to separate file. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS2_CHROMEOS_TIMEZONE_OPTIONS_UTIL_H_

	6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS2_CHROMEOS_TIMEZONE_OPTIONS_UTIL_H_

	7

	8 namespace base {

	9 class ListValue;

	10 }

	11

	12 namespace options2 {

	13

	14 // Creates a list of pairs of each timezone's ID and name.

	15 base::ListValue* GetTimezoneList();
	Joao da Silva 2012/07/16 11:44:54 Suggestion: make the return type scoped_ptr<base:: Suggestion: make the return type scoped_ptr<base::ListValue> so that it's clear that the caller owns the result. pneubeck2 2012/07/16 12:21:45 Done. Show quoted text On 2012/07/16 11:44:54, Joao da Silva wrote: > Suggestion: make the return type scoped_ptr<base::ListValue> so that it's clear > that the caller owns the result. Done.
	16

	17 } // namespace options2

	18

	19 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS2_CHROMEOS_TIMEZONE_OPTIONS_UTIL_H_

OLD	NEW