Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Side by Side Diff: chrome/browser/chromeos/device_settings_provider.cc

Issue 10689175: Refactored code for timezone settings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressed comments. Moved chromeos specific code from browser_options_handler to separate file. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/device_settings_provider.h" 5 #include "chrome/browser/chromeos/device_settings_provider.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/string_util.h" 12 #include "base/string_util.h"
13 #include "base/threading/thread_restrictions.h" 13 #include "base/threading/thread_restrictions.h"
14 #include "base/values.h" 14 #include "base/values.h"
15 #include "chrome/browser/browser_process.h" 15 #include "chrome/browser/browser_process.h"
16 #include "chrome/browser/chromeos/cros/cros_library.h" 16 #include "chrome/browser/chromeos/cros/cros_library.h"
17 #include "chrome/browser/chromeos/cros/network_library.h" 17 #include "chrome/browser/chromeos/cros/network_library.h"
18 #include "chrome/browser/chromeos/cros_settings.h" 18 #include "chrome/browser/chromeos/cros_settings.h"
19 #include "chrome/browser/chromeos/cros_settings_names.h" 19 #include "chrome/browser/chromeos/cros_settings_names.h"
20 #include "chrome/browser/chromeos/login/signed_settings_cache.h" 20 #include "chrome/browser/chromeos/login/signed_settings_cache.h"
21 #include "chrome/browser/chromeos/login/signed_settings_helper.h" 21 #include "chrome/browser/chromeos/login/signed_settings_helper.h"
22 #include "chrome/browser/chromeos/login/user_manager.h" 22 #include "chrome/browser/chromeos/login/user_manager.h"
23 #include "chrome/browser/policy/app_pack_updater.h" 23 #include "chrome/browser/policy/app_pack_updater.h"
24 #include "chrome/browser/policy/browser_policy_connector.h" 24 #include "chrome/browser/policy/browser_policy_connector.h"
25 #include "chrome/browser/policy/cloud_policy_constants.h" 25 #include "chrome/browser/policy/cloud_policy_constants.h"
26 #include "chrome/browser/policy/proto/chrome_device_policy.pb.h"
26 #include "chrome/browser/ui/options/options_util.h" 27 #include "chrome/browser/ui/options/options_util.h"
27 #include "chrome/common/chrome_notification_types.h" 28 #include "chrome/common/chrome_notification_types.h"
28 #include "chrome/installer/util/google_update_settings.h" 29 #include "chrome/installer/util/google_update_settings.h"
29 #include "content/public/browser/notification_service.h" 30 #include "content/public/browser/notification_service.h"
30 31
Joao da Silva 2012/07/16 11:44:54 Nit: remove extra newline
pneubeck2 2012/07/16 12:21:45 Done.
32
31 using google::protobuf::RepeatedPtrField; 33 using google::protobuf::RepeatedPtrField;
32 34
33 namespace em = enterprise_management; 35 namespace em = enterprise_management;
34 36
35 namespace chromeos { 37 namespace chromeos {
36 38
37 namespace { 39 namespace {
38 40
39 // List of settings handled by the DeviceSettingsProvider. 41 // List of settings handled by the DeviceSettingsProvider.
40 const char* kKnownSettings[] = { 42 const char* kKnownSettings[] = {
(...skipping 697 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 } 740 }
739 } 741 }
740 // Notify the observers we are done. 742 // Notify the observers we are done.
741 std::vector<base::Closure> callbacks; 743 std::vector<base::Closure> callbacks;
742 callbacks.swap(callbacks_); 744 callbacks.swap(callbacks_);
743 for (size_t i = 0; i < callbacks.size(); ++i) 745 for (size_t i = 0; i < callbacks.size(); ++i)
744 callbacks[i].Run(); 746 callbacks[i].Run();
745 } 747 }
746 748
747 } // namespace chromeos 749 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698