Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: utils/pub/io.dart

Issue 10689169: Use environment variables to find the Dart SDK and the Pub cache directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/pub/pub.dart » ('j') | utils/pub/pub.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index 84d01bc0fe4c925bad2bd0db19786c665ac6da1e..01f4524f33e33c9365ee5fc48549e998702cc7ac 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -333,13 +333,15 @@ Future<List<int>> consumeInputStream(InputStream stream) {
* piped streams won't be available in the result object.
*/
Future<PubProcessResult> runProcess(String executable, List<String> args,
- [workingDir, bool pipeStdout = false, bool pipeStderr = false]) {
+ [workingDir, environment, bool pipeStdout = false,
Bob Nystrom 2012/07/12 16:49:27 Can you type annotate this?
nweiz 2012/07/12 18:44:30 Done.
+ bool pipeStderr = false]) {
int exitCode;
final options = new ProcessOptions();
if (workingDir != null) {
options.workingDirectory = _getDirectory(workingDir).path;
}
+ options.environment = environment;
final process = Process.start(executable, args, options);
« no previous file with comments | « no previous file | utils/pub/pub.dart » ('j') | utils/pub/pub.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698