Run simple content shell test on Android bots.

Run simple content shell test on Android bots.


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146699

[darin (slow to review), 2012-07-11 23:35:26]

I'm not so sure that we want to add tools / scripts to the root of the content/
directory.  +jam for his thoughts / advice.

[Yaron, 2012-07-12 01:06:44]

lg modulo Darin's comment. At a minimum, this should be in content/android.

[Satish, 2012-07-12 14:43:16]

On 2012/07/12 01:06:44, Yaron wrote:
> lg modulo Darin's comment. At a minimum, this should be in content/android.

Why should it be under content/ and not under build/android like the rest of the
test runners?
http://src.chromium.org/viewvc/chrome/trunk/src/build/android/

[John Grabowski, 2012-07-12 18:29:14]

On 2012/07/12 14:43:16, Satish wrote:
> On 2012/07/12 01:06:44, Yaron wrote:
> > lg modulo Darin's comment. At a minimum, this should be in content/android.
> 
> Why should it be under content/ and not under build/android like the rest of
the
> test runners?
> http://src.chromium.org/viewvc/chrome/trunk/src/build/android/

http://codereview.chromium.org/10669030/ has a discussion of scripts like this.
I suggested build/android, but jam and mento suggested content/.

[John Grabowski, 2012-07-12 18:40:14]

LGTM *after* script file location settled by jam or mento (neither of which are
on the review list yet.)

https://chromiumcodereview.appspot.com/10689168/diff/7/content/simple_content...
File content/simple_content_shell_test.sh (right):

https://chromiumcodereview.appspot.com/10689168/diff/7/content/simple_content...
content/simple_content_shell_test.sh:21: if [ ! -f ${CONTENT_SHELL_APK} ]; then
If no args are passed to this script, [ ! -f ${CONTENT_SHELL_APK} ] returns 0,
which is not what you want.
Fix things by quoting it; e.g. "${CONTENT_SHELL_APK}"

[jam, 2012-07-13 15:11:29]

http://codereview.chromium.org/10689168/diff/7/content/simple_content_shell_t...
File content/simple_content_shell_test.sh (right):

http://codereview.chromium.org/10689168/diff/7/content/simple_content_shell_t...
content/simple_content_shell_test.sh:1: #!/bin/bash
nit: put this in content/shell/android?

[navabi, 2012-07-13 20:05:38]

PTAL.

http://codereview.chromium.org/10689168/diff/7/content/simple_content_shell_t...
File content/simple_content_shell_test.sh (right):

http://codereview.chromium.org/10689168/diff/7/content/simple_content_shell_t...
content/simple_content_shell_test.sh:21: if [ ! -f ${CONTENT_SHELL_APK} ]; then
On 2012/07/12 18:40:14, John Grabowski wrote:
> If no args are passed to this script, [ ! -f ${CONTENT_SHELL_APK} ] returns 0,
> which is not what you want.
> Fix things by quoting it; e.g. "${CONTENT_SHELL_APK}"

Done.

[John Grabowski, 2012-07-13 20:17:34]

On 2012/07/13 20:05:38, navabi wrote:
> PTAL.
> 
>
http://codereview.chromium.org/10689168/diff/7/content/simple_content_shell_t...
> File content/simple_content_shell_test.sh (right):
> 
>
http://codereview.chromium.org/10689168/diff/7/content/simple_content_shell_t...
> content/simple_content_shell_test.sh:21: if [ ! -f ${CONTENT_SHELL_APK} ];
then
> On 2012/07/12 18:40:14, John Grabowski wrote:
> > If no args are passed to this script, [ ! -f ${CONTENT_SHELL_APK} ] returns
0,
> > which is not what you want.
> > Fix things by quoting it; e.g. "${CONTENT_SHELL_APK}"
> 
> Done.

You did not move the script to the location suggested by jam

[navabi, 2012-07-13 20:43:55]

PTAL.

[John Grabowski, 2012-07-13 21:07:04]

On 2012/07/13 20:43:55, navabi wrote:
> PTAL.

Still LGTM

[commit-bot: I haz the power, 2012-07-13 23:25:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/10689168/10001

[commit-bot: I haz the power, 2012-07-14 01:09:13]

Change committed as 146699