[NTP4] Remove promo text horizontal transitions on NTP opening.

[NTP4] Remove promo text horizontal transitions on NTP opening.

R=estade@chromium.org
BUG=136944
TEST=No animation of the promo text when opening an NTP.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148051

[Evan Stade, 2012-07-12 01:45:18]

what's this about? you should make the description clearer (which horizontal
transitions are you removing?). Who decided they were annoying?

[Dan Beam, 2012-07-12 01:50:31]

On 2012/07/12 01:45:18, Evan Stade wrote:
> what's this about? you should make the description clearer (which horizontal
> transitions are you removing?). Who decided they were annoying?

check your @google.com email for context

[Evan Stade, 2012-07-12 02:08:19]

you still need to create a bug for this and improve the CL description. What's
more, I don't see anyone complaining about the horizontal transitions when
switching pages, only when the promo first comes into view.

[Dan Beam, 2012-07-12 02:28:01]

On 2012/07/12 02:08:19, Evan Stade wrote:
> you still need to create a bug for this and improve the CL description.

http://crbug.com/136944

> What's more, I don't see anyone complaining about the horizontal transitions
when
> switching pages, only when the promo first comes into view.

At the moment I don't believe there's any visible horizontal transitions when
switching pages (only opacity), but there are when resizing the tile grid (via
resizing the browser window).  I re-examined how this looks without transitions
in margin, and it looks fine to me (almost exactly the same) while re-sizing
with .animating-tile-page applied and the grid layout shifting from 6xN <-> 3xN.
 You can check it out in action tomorrow if you want.

[Dan Beam, 2012-07-13 02:42:40]

ping

[Evan Stade, 2012-07-13 06:22:36]

On 2012/07/12 02:28:01, Dan Beam wrote:
> On 2012/07/12 02:08:19, Evan Stade wrote:
> > you still need to create a bug for this and improve the CL description.
> 
> http://crbug.com/136944
> 
> > What's more, I don't see anyone complaining about the horizontal transitions
> when
> > switching pages, only when the promo first comes into view.
> 
> At the moment I don't believe there's any visible horizontal transitions when
> switching pages (only opacity), but there are when resizing the tile grid (via
> resizing the browser window).  I re-examined how this looks without
transitions
> in margin, and it looks fine to me (almost exactly the same) while re-sizing
> with .animating-tile-page applied and the grid layout shifting from 6xN <->
3xN.
>  You can check it out in action tomorrow if you want.

I think you're missing the point about the CL description. You are not removing
all horizontal animations from the NTP. It's a very specific animation you're
changing. You are also not just removing it when the page is opening. You're
removing it when shifting between wide and narrow, which I don't think is right
(although I can't see it).

[Dan Beam, 2012-07-13 07:56:46]

On 2012/07/13 06:22:36, Evan Stade wrote:
> On 2012/07/12 02:28:01, Dan Beam wrote:
> > On 2012/07/12 02:08:19, Evan Stade wrote:
> > > you still need to create a bug for this and improve the CL description.
> > 
> > http://crbug.com/136944
> > 
> > > What's more, I don't see anyone complaining about the horizontal
transitions
> > when
> > > switching pages, only when the promo first comes into view.
> > 
> > At the moment I don't believe there's any visible horizontal transitions
when
> > switching pages (only opacity), but there are when resizing the tile grid
(via
> > resizing the browser window).  I re-examined how this looks without
> transitions
> > in margin, and it looks fine to me (almost exactly the same) while re-sizing
> > with .animating-tile-page applied and the grid layout shifting from 6xN <->
> 3xN.
> >  You can check it out in action tomorrow if you want.
> 
> I think you're missing the point about the CL description. You are not
removing
> all horizontal animations from the NTP. It's a very specific animation you're
> changing. You are also not just removing it when the page is opening. You're
> removing it when shifting between wide and narrow, which I don't think is
right
> (although I can't see it).

we can just look at it together. I think it's seriously not worth keeping.

[Dan Beam, 2012-07-19 09:18:22]

well, that was easier than I thought... I still dislike that when transitioning
(at least on mac) from 3xN -> 6xN grids the promo text lags behind the app icons
or most visited tiles...

[Dan Beam, 2012-07-21 03:39:18]

ok, fixed as we talked about a day or two ago, ptal

[Evan Stade, 2012-07-23 21:51:15]

https://chromiumcodereview.appspot.com/10689164/diff/9002/chrome/browser/reso...
File chrome/browser/resources/ntp4/tile_page.js (right):

https://chromiumcodereview.appspot.com/10689164/diff/9002/chrome/browser/reso...
chrome/browser/resources/ntp4/tile_page.js:846: * @return {number} The animated
left margin for the current layout.
needs better English description of "animated left margin"

[Dan Beam, 2012-07-24 00:52:56]

https://chromiumcodereview.appspot.com/10689164/diff/9002/chrome/browser/reso...
File chrome/browser/resources/ntp4/tile_page.js (right):

https://chromiumcodereview.appspot.com/10689164/diff/9002/chrome/browser/reso...
chrome/browser/resources/ntp4/tile_page.js:846: * @return {number} The animated
left margin for the current layout.
On 2012/07/23 21:51:15, Evan Stade wrote:
> needs better English description of "animated left margin"

Done.

[Evan Stade, 2012-07-24 00:56:56]

lgtm

[commit-bot: I haz the power, 2012-07-24 03:06:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/10689164/9004

[commit-bot: I haz the power, 2012-07-24 06:02:32]

Change committed as 148051