Issue 10689162: Remove deprecated step that copies ui_unittests to gfx_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10689162: Remove deprecated step that copies ui_unittests to gfx_unittests (Closed)

Created:
8 years, 5 months ago by James Cook

Modified:
8 years, 4 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove deprecated step that copies ui_unittests to gfx_unittests Also clean up some dependencies on gfx_unittests by changing them to ui_unittests BUG=133864 TEST=build ui_unittests, check buildbots Abandoned - dhollawa took care of this.

Patch Set 1 #

Patch Set 2 : rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -35 lines)			Patch
	M	build/all.gyp	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
	M	ui/ui.gyp	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Cook

Robert, this is cleaning up an old TODO. I don't think we need this copy ...

8 years, 5 months ago (2012-07-11 20:09:20 UTC) #1

Robert Sesek

8 years, 5 months ago (2012-07-11 22:14:48 UTC) #2

This is correct && LGTM, but I think this cannot be submitted yet per the latest
comment in http://code.google.com/p/chromium/issues/detail?id=133864 (also set
the BUG= to that).

Expand Messages | Collapse Messages