Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10689159: Android: a few minor improvements for the test runner. (Closed)

Created:
8 years, 5 months ago by bulach
Modified:
8 years, 5 months ago
Reviewers:
John Knottenbelt
CC:
chromium-reviews, Wei James(wistoch), yongsheng
Visibility:
Public.

Description

Android: a few minor improvements for the test runner. - We had a few options with default=True, which made them not really optional. Instead, use an option with action='store_true' which is False by default. - Uses buildbot_report.py rather than duplicate the functionality. - Removes default params from SingleTestRunner to make it more explicit. BUG= TEST=existing android tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146318

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments #

Patch Set 3 : Removes --apk from buildbot_functions.sh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -86 lines) Patch
M build/android/buildbot_functions.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/buildbot_report.py View 1 chunk +9 lines, -0 lines 0 comments Download
M build/android/pylib/single_test_runner.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/run_tests.py View 1 21 chunks +75 lines, -83 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bulach
8 years, 5 months ago (2012-07-11 16:10:33 UTC) #1
John Knottenbelt
lgtm, thanks Marcus! One inline comment where I think you meant PrintError() instead of Error() ...
8 years, 5 months ago (2012-07-11 17:02:13 UTC) #2
bulach
thanks john! comment addressed.. http://codereview.chromium.org/10689159/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): http://codereview.chromium.org/10689159/diff/1/build/android/run_tests.py#newcode173 build/android/run_tests.py:173: buildbot_report.Error() On 2012/07/11 17:02:13, John ...
8 years, 5 months ago (2012-07-11 17:12:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10689159/8001
8 years, 5 months ago (2012-07-12 07:31:23 UTC) #4
commit-bot: I haz the power
Try job failure for 10689159-8001 (retry) (retry) on mac_rel for step "browser_tests". It's a second ...
8 years, 5 months ago (2012-07-12 09:00:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10689159/8001
8 years, 5 months ago (2012-07-12 09:22:26 UTC) #6
commit-bot: I haz the power
Try job failure for 10689159-8001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-12 10:19:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10689159/8001
8 years, 5 months ago (2012-07-12 10:27:32 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 11:35:05 UTC) #9
Change committed as 146318

Powered by Google App Engine
This is Rietveld 408576698