Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10689157: Switch to TimeDelta interfaces for TestTimeouts in sync code. (Closed)

Created:
8 years, 5 months ago by Ted Vessenes
Modified:
8 years, 5 months ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Switch to TimeDelta interfaces for TestTimeouts in sync code. R=akalin@chromium.org BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146282

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits. #

Patch Set 3 : Fix timeout code. #

Patch Set 4 : Fix compilation bug. #

Patch Set 5 : Fix error messaging again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.cc View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ted Vessenes
8 years, 5 months ago (2012-07-11 10:10:34 UTC) #1
akalin
LGTM https://chromiumcodereview.appspot.com/10689157/diff/1/chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc File chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc (right): https://chromiumcodereview.appspot.com/10689157/diff/1/chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc#newcode42 chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc:42: // DoWork hasn't executed within action_timeout() ms. remove ...
8 years, 5 months ago (2012-07-11 20:35:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10689157/4001
8 years, 5 months ago (2012-07-11 22:25:34 UTC) #3
commit-bot: I haz the power
Try job failure for 10689157-4001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-11 22:59:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10689157/6002
8 years, 5 months ago (2012-07-12 00:52:40 UTC) #5
commit-bot: I haz the power
Try job failure for 10689157-6002 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-12 01:20:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10689157/6004
8 years, 5 months ago (2012-07-12 01:34:42 UTC) #7
commit-bot: I haz the power
Try job failure for 10689157-6004 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-12 01:55:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10689157/1012
8 years, 5 months ago (2012-07-12 02:09:04 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 03:21:37 UTC) #10 
Change committed as 146282

Powered by Google App Engine
This is Rietveld 408576698