Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10689155: [NTP4] Fix pane switcher images. (Closed)

Created:
8 years, 5 months ago by Dan Beam
Modified:
8 years, 5 months ago
CC:
chromium-reviews, flackr, Nico
Visibility:
Public.

Description

[NTP4] Fix pane switcher images while we figure out the difference between <structure type="chrome_html">s and <include type="BINDATA">s. This is partial revert of r145332. R=tbreisacher@chromium.org BUG=136389 TEST=Pane switchers have arrows again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/browser_resources.grd View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dan Beam
8 years, 5 months ago (2012-07-11 03:43:13 UTC) #1
Tyler Breisacher (Chromium)
On 2012/07/11 03:43:13, Dan Beam wrote: lgtm as a quick fix but of course thakis@ ...
8 years, 5 months ago (2012-07-11 04:10:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/10689155/1
8 years, 5 months ago (2012-07-11 04:39:39 UTC) #3
commit-bot: I haz the power
Change committed as 146063
8 years, 5 months ago (2012-07-11 06:01:28 UTC) #4
Nico
This breaks hidpi images on the NTP, so this isn't the right fix. On Jul ...
8 years, 5 months ago (2012-07-11 08:31:22 UTC) #5
Dan Beam
8 years, 5 months ago (2012-07-11 17:16:53 UTC) #6 
On 2012/07/11 08:31:22, Nico wrote:
> This breaks hidpi images on the NTP, so this isn't the right fix.

It's just temporary.

> On Jul 11, 2012 5:43 AM, <mailto:dbeam@chromium.org> wrote:
> 
> > Reviewers: Tyler Breisacher,
> >
> > Description:
> > [NTP4] Fix pane switcher images.  This is partial revert of r145332.
> >
> > mailto:R=tbreisacher@chromium.org
> > BUG=136389
> > TEST=Pane switchers have arrows again.
> >
> >
> > Please review this at
>
https://chromiumcodereview.**appspot.com/10689155/%3Chttps://chromiumcoderevi...>
> >
> > SVN Base:
>
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
> >
> > Affected files:
> >   M chrome/browser/browser_**resources.grd
> >
> >
> > Index: chrome/browser/browser_**resources.grd
> > diff --git a/chrome/browser/browser_**resources.grd
> > b/chrome/browser/browser_**resources.grd
> > index a6e614fd0d9608e2b1ac1df456c2a6**793febb796..**
> > 03f9b78f65f7df5244ab6e1a18f840**ea39d1d262 100644
> > --- a/chrome/browser/browser_**resources.grd
> > +++ b/chrome/browser/browser_**resources.grd
> > @@ -20,11 +20,6 @@
> >        </if>
> >        <structure name="IDR_HELP_CSS" file="resources\help\help.css"
> > flattenhtml="true" type="chrome_html" />
> >        <structure name="IDR_HELP_HTML" file="resources\help\help.**html"
> > flattenhtml="true" type="chrome_html" />
> > -      <structure name="IDR_EXTENSIONS_HTML"
> file="resources\extensions\**extensions.html"
> > flattenhtml="true" type="chrome_html" />
> > -      <structure name="IDR_NEW_TAB_4_HTML" file="resources\ntp4\new_tab.*
> > *html" flattenhtml="true" type="chrome_html" />
> > -      <structure name="IDR_NEW_TAB_4_THEME_CSS"
> > file="resources\ntp4\new_tab_**theme.css" flattenhtml="true"
> > type="chrome_html" />
> > -      <structure name="IDR_NEW_TAB_SEARCH_HTML"
> > file="resources\ntp_search\**new_tab.html" flattenhtml="true"
> > type="chrome_html" />
> > -      <structure name="IDR_NEW_TAB_SEARCH_**THEME_CSS"
> > file="resources\ntp_search\**new_tab_theme.css" flattenhtml="true"
> > type="chrome_html" />
> >        <structure name="IDR_ABOUT_VERSION_HTML"
> > file="resources\about_version.**html" flattenhtml="true"
> > allowexternalscript="true" type="chrome_html" />
> >      </structures>
> >      <includes>
> > @@ -70,6 +65,7 @@
> >        <include name="IDR_EXTENSION_INFO_CSS" file="resources\extensions\*
> > *extension_info.css" flattenhtml="true" type="BINDATA" />
> >        <include name="IDR_EXTENSION_INFO_HTML" file="resources\extensions\
> > **extension_info.html" flattenhtml="true" type="BINDATA" />
> >        <include name="IDR_EXTENSION_INFO_JS"
> file="resources\extensions\**extension_info.js"
> > flattenhtml="true" type="BINDATA" />
> > +      <include name="IDR_EXTENSIONS_HTML"
> file="resources\extensions\**extensions.html"
> > flattenhtml="true" type="BINDATA" />
> >        <include name="IDR_EXTENSIONS_JS"
> file="resources\extensions\**extensions.js"
> > flattenhtml="true" type="BINDATA" />
> >        <include name="IDR_FLAGS_HTML" file="resources\flags.html"
> > flattenhtml="true" type="BINDATA" />
> >        <include name="IDR_FLAGS_HTML_WARNING"
> > file="resources\flags_warning.**html" flattenhtml="true" type="BINDATA" />
> > @@ -93,6 +89,10 @@
> >        <include name="IDR_PREDICTORS_HTML"
> file="resources\predictors\**predictors.html"
> > flattenhtml="true" allowexternalscript="true" type="BINDATA" />
> >        <include name="IDR_PREDICTORS_JS"
> file="resources\predictors\**predictors.js"
> > flattenhtml="true" type="BINDATA" />
> >        <include name="IDR_NEW_INCOGNITO_TAB_**THEME_CSS"
> > file="resources\new_incognito_**tab_theme.css" flattenhtml="true"
> > type="BINDATA" />
> > +      <include name="IDR_NEW_TAB_4_HTML"
> file="resources\ntp4\new_tab.**html"
> > flattenhtml="true" type="BINDATA" />
> > +      <include name="IDR_NEW_TAB_4_THEME_CSS"
> > file="resources\ntp4\new_tab_**theme.css" flattenhtml="true"
> > type="BINDATA" />
> > +      <include name="IDR_NEW_TAB_SEARCH_HTML" file="resources\ntp_search\
> > **new_tab.html" flattenhtml="true" type="BINDATA" />
> > +      <include name="IDR_NEW_TAB_SEARCH_**THEME_CSS"
> > file="resources\ntp_search\**new_tab_theme.css" flattenhtml="true"
> > type="BINDATA" />
> >        <include name="IDR_NOTIFICATION_1LINE_**HTML"
> > file="resources\notification_**1line.html" flattenhtml="true"
> > type="BINDATA" />
> >        <include name="IDR_NOTIFICATION_2LINE_**HTML"
> > file="resources\notification_**2line.html" flattenhtml="true"
> > type="BINDATA" />
> >        <include name="IDR_NOTIFICATION_ICON_**HTML"
> > file="resources\notification_**icon.html" type="BINDATA" />
> >
> >
> >

Powered by Google App Engine
This is Rietveld 408576698