Fix BubbleBorder wrong arrow for BOTTOM_LEFT and RIGHT_TOP.

Fix BubbleBorder wrong arrow for BOTTOM_LEFT and RIGHT_TOP.

BUG=136603
TEST=Verify bubble arrow is drawn correctly when arrow location is BOTTOM_LEFT and RIGHT_TOP.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146155

[Peter Kasting, 2012-07-10 22:45:26]

LGTM

http://codereview.chromium.org/10689145/diff/1/ui/views/bubble/bubble_border.cc
File ui/views/bubble/bubble_border.cc (right):

http://codereview.chromium.org/10689145/diff/1/ui/views/bubble/bubble_border....
ui/views/bubble/bubble_border.cc:459: const int offset_to_next_vertex =
Nit: Slightly simpler:

  const bool positive_offset = is_horizontal ?
      is_arrow_on_top(arrow_location_) : is_arrow_on_left(arrow_location_);
  const int offset_to_next_vertex = positive_offset ?
      kArrowInteriorHeight : -kArrowInteriorHeight;

[xiyuan, 2012-07-11 00:53:55]

http://codereview.chromium.org/10689145/diff/1/ui/views/bubble/bubble_border.cc
File ui/views/bubble/bubble_border.cc (right):

http://codereview.chromium.org/10689145/diff/1/ui/views/bubble/bubble_border....
ui/views/bubble/bubble_border.cc:459: const int offset_to_next_vertex =
On 2012/07/10 22:45:27, Peter Kasting wrote:
> Nit: Slightly simpler:
> 
>   const bool positive_offset = is_horizontal ?
>       is_arrow_on_top(arrow_location_) : is_arrow_on_left(arrow_location_);
>   const int offset_to_next_vertex = positive_offset ?
>       kArrowInteriorHeight : -kArrowInteriorHeight;

Changed. I like yours better.

[commit-bot: I haz the power, 2012-07-11 16:56:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10689145/3001

[commit-bot: I haz the power, 2012-07-11 16:56:08]

Presubmit check for 10689145-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui/views

[xiyuan, 2012-07-11 16:57:30]

Ben, please help with owner's review. Thanks. :)

[Ben Goodger (Google), 2012-07-11 17:02:36]

lgtm

[commit-bot: I haz the power, 2012-07-11 17:05:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10689145/3001

[commit-bot: I haz the power, 2012-07-11 18:38:42]

Change committed as 146155