Issue 10689142: Log cancellation error codes at the URLRequest level to NetLog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10689142: Log cancellation error codes at the URLRequest level to NetLog. (Closed)

Created:
8 years, 5 months ago by mmenke

Modified:
8 years, 5 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Log cancellation error codes at the URLRequest level to NetLog. In some cases this may result in redundant logging, but this is needed to log cancellations from third parties. R=eroman@chomium.org BUG=108055 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145975

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	net/base/net_log.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	net/url_request/url_request.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mmenke

On 2012/07/10 21:06:00, eroman wrote: > lgtm Thank ye kindly.

8 years, 5 months ago (2012-07-10 21:09:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10689142/1

8 years, 5 months ago (2012-07-10 21:10:18 UTC) #4

commit-bot: I haz the power

8 years, 5 months ago (2012-07-10 22:44:32 UTC) #5

Try job failure for 10689142-1 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages