Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: src/parser.cc

Issue 10689134: Correctly report octal literals in strict mode when preparsing. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4344 matching lines...) Expand 10 before | Expand all | Expand 10 after
4355 virtual void LogAsciiSymbol(int start, Vector<const char> literal) { } 4355 virtual void LogAsciiSymbol(int start, Vector<const char> literal) { }
4356 virtual void LogUtf16Symbol(int start, Vector<const uc16> literal) { } 4356 virtual void LogUtf16Symbol(int start, Vector<const uc16> literal) { }
4357 4357
4358 // Logs an error message and marks the log as containing an error. 4358 // Logs an error message and marks the log as containing an error.
4359 // Further logging will be ignored, and ExtractData will return a vector 4359 // Further logging will be ignored, and ExtractData will return a vector
4360 // representing the error only. 4360 // representing the error only.
4361 virtual void LogMessage(int start, 4361 virtual void LogMessage(int start,
4362 int end, 4362 int end,
4363 const char* message, 4363 const char* message,
4364 const char* argument_opt) { 4364 const char* argument_opt) {
4365 if (has_error_) return;
4365 has_error_ = true; 4366 has_error_ = true;
4366 start_ = start; 4367 start_ = start;
4367 end_ = end; 4368 end_ = end;
4368 message_ = message; 4369 message_ = message;
4369 argument_opt_ = argument_opt; 4370 argument_opt_ = argument_opt;
4370 } 4371 }
4371 4372
4372 virtual int function_position() { return 0; } 4373 virtual int function_position() { return 0; }
4373 4374
4374 virtual int symbol_position() { return 0; } 4375 virtual int symbol_position() { return 0; }
(...skipping 1695 matching lines...) Expand 10 before | Expand all | Expand 10 after
6070 ASSERT(info->isolate()->has_pending_exception()); 6071 ASSERT(info->isolate()->has_pending_exception());
6071 } else { 6072 } else {
6072 result = parser.ParseProgram(); 6073 result = parser.ParseProgram();
6073 } 6074 }
6074 } 6075 }
6075 info->SetFunction(result); 6076 info->SetFunction(result);
6076 return (result != NULL); 6077 return (result != NULL);
6077 } 6078 }
6078 6079
6079 } } // namespace v8::internal 6080 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698