Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 10689117: Extensions Docs Server: Support APIs with properties (Closed)

Created:
8 years, 5 months ago by cduvall
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, clintstaley, chebert
Visibility:
Public.

Description

Extensions Docs Server: Support APIs with properties Added a template for API properties. I also added templates for the privacy API, which has properties. BUG=131095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145786

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Storage API looking good #

Total comments: 28

Patch Set 3 : fixes #

Total comments: 3

Patch Set 4 : nits #

Patch Set 5 : cl upload problems #

Patch Set 6 : cl upload problems fixed? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -51 lines) Patch
chrome/common/extensions/docs/server2/handlebar_dict_generator.py View 1 2 3 4 chunks +18 lines, -3 lines 0 comments Download
chrome/common/extensions/docs/server2/handlebar_dict_generator_test.py View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/static/css/api.css View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/static/css/site.css View 1 1 chunk +8 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/templates/private/api_property.html View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/templates/private/api_reference.html View 1 2 chunks +7 lines, -1 line 0 comments Download
chrome/common/extensions/docs/server2/templates/private/function.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
chrome/common/extensions/docs/server2/templates/private/table_of_contents.html View 1 2 1 chunk +6 lines, -30 lines 0 comments Download
chrome/common/extensions/docs/server2/templates/private/toc_events.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/templates/private/toc_functions.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/templates/private/toc_properties.html View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/templates/private/toc_types.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/templates/private/type.html View 1 1 chunk +5 lines, -1 line 0 comments Download
chrome/common/extensions/docs/server2/templates/private/variable_type.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json View 1 7 chunks +24 lines, -11 lines 0 comments Download
tools/json_schema_compiler/model.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cduvall
Added support for APIs with properties. Funny note: the current privacy API description has all ...
8 years, 5 months ago (2012-07-05 20:41:35 UTC) #1
cduvall
+kalman
8 years, 5 months ago (2012-07-05 20:41:56 UTC) #2
not at google - send to devlin
I'm not sure we should submit this until rendering properties works properly with the storage ...
8 years, 5 months ago (2012-07-06 02:14:29 UTC) #3
cduvall
Storage API has everything the old docs had minus events. http://codereview.chromium.org/10689117/diff/2001/chrome/common/extensions/docs/server2/handlebar_dict_generator.py File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right): http://codereview.chromium.org/10689117/diff/2001/chrome/common/extensions/docs/server2/handlebar_dict_generator.py#newcode118 ...
8 years, 5 months ago (2012-07-06 20:32:11 UTC) #4
not at google - send to devlin
http://codereview.chromium.org/10689117/diff/1009/chrome/common/extensions/docs/server2/handlebar_dict_generator.py File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right): http://codereview.chromium.org/10689117/diff/1009/chrome/common/extensions/docs/server2/handlebar_dict_generator.py#newcode39 chrome/common/extensions/docs/server2/handlebar_dict_generator.py:39: return ('<code>%s</code>' % All HTML should be the concern ...
8 years, 5 months ago (2012-07-09 11:01:20 UTC) #5
cduvall
http://codereview.chromium.org/10689117/diff/1009/chrome/common/extensions/docs/server2/handlebar_dict_generator.py File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right): http://codereview.chromium.org/10689117/diff/1009/chrome/common/extensions/docs/server2/handlebar_dict_generator.py#newcode39 chrome/common/extensions/docs/server2/handlebar_dict_generator.py:39: return ('<code>%s</code>' % On 2012/07/09 11:01:20, kalman wrote: > ...
8 years, 5 months ago (2012-07-09 17:50:39 UTC) #6
not at google - send to devlin
lgtm http://codereview.chromium.org/10689117/diff/1009/chrome/common/extensions/docs/server2/static/css/api.css File chrome/common/extensions/docs/server2/static/css/api.css (right): http://codereview.chromium.org/10689117/diff/1009/chrome/common/extensions/docs/server2/static/css/api.css#newcode17 chrome/common/extensions/docs/server2/static/css/api.css:17: text-transform: lowercase; On 2012/07/09 17:50:40, cduvall wrote: > ...
8 years, 5 months ago (2012-07-09 23:05:33 UTC) #7
cduvall
8 years, 5 months ago (2012-07-09 23:22:58 UTC) #8
Done. CL upload was having some problems but I think its good now.

https://chromiumcodereview.appspot.com/10689117/diff/1009/chrome/common/exten...
File chrome/common/extensions/docs/server2/static/css/api.css (right):

https://chromiumcodereview.appspot.com/10689117/diff/1009/chrome/common/exten...
chrome/common/extensions/docs/server2/static/css/api.css:17: text-transform:
lowercase;
On 2012/07/09 23:05:34, kalman wrote:
> On 2012/07/09 17:50:40, cduvall wrote:
> > On 2012/07/09 11:01:20, kalman wrote:
> > > Can this be done in handlebar_dict_generator instead?
> > > 
> > > I don't actually understand what it's necessary for.
> > 
> > This is necessary because when types have functions they show them prefixed
by
> > the type name (with a lowercase first letter, see
> >
http://code.google.com/chrome/extensions/storage.html#method-StorageArea-get).
> > To do this in handlebar_dict_generator we would need to store a version of
the
> > type name with an uppercase first letter, and one with a lowercase first
> letter,
> > because the uppercase version is also used.
> 
> Ah, cool. Comment?

Done.

https://chromiumcodereview.appspot.com/10689117/diff/18001/chrome/common/exte...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10689117/diff/18001/chrome/common/exte...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:138: if
isinstance(property_, model.Property) and property_.has_value:
On 2012/07/09 23:05:34, kalman wrote:
> Oh, property_ isn't a Property? Oops. I guess that's what you get for not
having
> types :\
> 
> Sorry to do this to you again, but in that case could you move the check back
> into GenerateProperty, like (line 133)
> 
> if property_.has_value:
>   if isinstance(property_.value, int):
>   ...
> else:
>   self._RenderTypeInformation

Done.

Powered by Google App Engine
This is Rietveld 408576698