Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10689116: Cleanup: better session restore UI. (Closed)

Created:
8 years, 5 months ago by marja
Modified:
8 years, 5 months ago
Reviewers:
sail, Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Cleanup: removing better session restore UI changes. No UI changes were shipped (apart from the startup option string change). BUG=133904 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146084

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -293 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.js View 1 8 chunks +0 lines, -126 lines 0 comments Download
M chrome/browser/resources/options2/content_settings.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/content_settings.js View 1 3 chunks +0 lines, -74 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/options.js View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/options2/session_restore_overlay.html View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/resources/options2/session_restore_overlay.js View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/content_settings_handler.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
marja
Hi, could you review the following parts: estade: all sail: chrome/browser/profiles/*
8 years, 5 months ago (2012-07-05 15:18:04 UTC) #1
Evan Stade
lgtm
8 years, 5 months ago (2012-07-10 07:33:23 UTC) #2
sail
profiles/* LGTM Please update the change description to reflect that you're removing something.
8 years, 5 months ago (2012-07-10 21:08:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10689116/1
8 years, 5 months ago (2012-07-11 06:54:40 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/webui/options2/browser_options_handler2.cc: While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/options2/browser_options_handler2.cc ...
8 years, 5 months ago (2012-07-11 06:54:46 UTC) #5
marja
Thanks for review! Updated the description.
8 years, 5 months ago (2012-07-11 07:10:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10689116/6001
8 years, 5 months ago (2012-07-11 07:10:36 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 08:48:24 UTC) #8 
Change committed as 146084

Powered by Google App Engine
This is Rietveld 408576698