Aura: Have ui::Layer implement WebKit::WebExternalTextureLayerClient

ui/compositor/compositor.h

Index: ui/compositor/compositor.h
diff --git a/ui/compositor/compositor.h b/ui/compositor/compositor.h
index 735954f4df030e9e21527205a25b4d08a0a7b966..09212dbd194d18fdd3c0177eb537fa4375d7ada4 100644
--- a/ui/compositor/compositor.h
+++ b/ui/compositor/compositor.h
@@ -6,6 +6,9 @@
 #define UI_COMPOSITOR_COMPOSITOR_H_
 #pragma once
 
+#include <vector>
+
+#include "base/callback.h"
 #include "base/hash_tables.h"
 #include "base/memory/ref_counted.h"
 #include "base/observer_list.h"
@@ -210,6 +213,7 @@ class COMPOSITOR_EXPORT Compositor
                                    float scaleFactor);
   virtual WebKit::WebGraphicsContext3D* createContext3D();
   virtual void didRebindGraphicsContext(bool success);
+  virtual void didCommit();
   virtual void didCommitAndDrawFrame();
   virtual void didCompleteSwapBuffers();
   virtual void scheduleComposite();
@@ -217,6 +221,9 @@ class COMPOSITOR_EXPORT Compositor
   int last_started_frame() { return last_started_frame_; }
   int last_ended_frame() { return last_ended_frame_; }
 
+  void AddDidCommitCallback(

[piman, 2012/07/09 22:40:01]

It would be good to have the name and/or comments indicate that in the
single-threaded case, this would run the callback immediately (in a re-entrant
way). It can be unexpected to the user

[jonathan.backer, 2012/07/11 21:02:03]

You're right: it's confusing. I changed it to fire on all didCommit() signals.
If you'd like, I can add this to CompositorObserver instead (although that's
getting pretty full).

Based on our conversation, I dug deeper. In the single-threaded case,
didCommit() is signaled halfway through a draw cycle. Whereas in the threaded
case, didCommit() happens quickly after a setNeedsCommit() and can occur many
times before a draw cycle.

[piman, 2012/07/12 00:18:09]

I'd rather be consistent.
Ok, thanks.

+      const base::Callback<void(ui::Compositor*)>& callback);
+
  private:
   friend class base::RefCounted<Compositor>;
 
@@ -252,6 +259,9 @@ class COMPOSITOR_EXPORT Compositor
   int last_ended_frame_;
 
   bool disable_schedule_composite_;
+
+  std::vector< base::Callback<void(ui::Compositor*)> >
+      did_commit_callbacks_;
 };
 
 }  // namespace ui