Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 10689102: Copying gdbserver to the apk to enable native debugging for native_test_apk (Closed)

Created:
8 years, 5 months ago by Shouqun Liu
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Copying gdbserver to the apk to enable native debugging for native_test_apk BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145603

Patch Set 1 #

Patch Set 2 : Refine the patch #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M testing/android/generate_native_test.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/native_test_apk.xml View 2 chunks +20 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Shouqun Liu
copy gdbserver to the apk in case we need to debug the native_tests (DumpRenderTree, unit_tests), ...
8 years, 5 months ago (2012-07-04 08:40:18 UTC) #1
Shouqun Liu
8 years, 5 months ago (2012-07-06 00:33:58 UTC) #2
bulach
+digit, he knows all about gdb
8 years, 5 months ago (2012-07-06 09:38:54 UTC) #3
bulach
thanks! I have one question below... http://codereview.chromium.org/10689102/diff/3001/testing/android/native_test_apk.xml File testing/android/native_test_apk.xml (right): http://codereview.chromium.org/10689102/diff/3001/testing/android/native_test_apk.xml#newcode72 testing/android/native_test_apk.xml:72: <echo message="Copying gdbserver ...
8 years, 5 months ago (2012-07-06 09:59:12 UTC) #4
digit1
lgtm lgtm For the record, to be able to debug an application on Android, one ...
8 years, 5 months ago (2012-07-06 13:17:54 UTC) #5
bulach
lgtm then :) thanks for the clarification, makes sense!
8 years, 5 months ago (2012-07-06 13:45:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10689102/3001
8 years, 5 months ago (2012-07-06 16:21:51 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-06 17:49:52 UTC) #8
Change committed as 145603

Powered by Google App Engine
This is Rietveld 408576698