Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 10689097: Enforce the 'requirements' field in manifests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Conforming to the doc Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/base64.h" 8 #include "base/base64.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/file_util.h" 12 #include "base/file_util.h"
13 #include "base/string_number_conversions.h" 13 #include "base/string_number_conversions.h"
14 #include "base/utf_string_conversions.h" 14 #include "base/utf_string_conversions.h"
15 #include "base/values.h" 15 #include "base/values.h"
16 #include "base/version.h" 16 #include "base/version.h"
17 #include "chrome/browser/browser_process.h" 17 #include "chrome/browser/browser_process.h"
18 #include "chrome/browser/debugger/devtools_window.h" 18 #include "chrome/browser/debugger/devtools_window.h"
19 #include "chrome/browser/extensions/crx_installer.h" 19 #include "chrome/browser/extensions/crx_installer.h"
20 #include "chrome/browser/extensions/extension_disabled_ui.h" 20 #include "chrome/browser/extensions/extension_disabled_ui.h"
21 #include "chrome/browser/extensions/extension_error_reporter.h"
21 #include "chrome/browser/extensions/extension_host.h" 22 #include "chrome/browser/extensions/extension_host.h"
22 #include "chrome/browser/extensions/extension_service.h" 23 #include "chrome/browser/extensions/extension_service.h"
23 #include "chrome/browser/extensions/extension_system.h" 24 #include "chrome/browser/extensions/extension_system.h"
24 #include "chrome/browser/extensions/extension_warning_set.h" 25 #include "chrome/browser/extensions/extension_warning_set.h"
25 #include "chrome/browser/extensions/lazy_background_task_queue.h" 26 #include "chrome/browser/extensions/lazy_background_task_queue.h"
26 #include "chrome/browser/extensions/unpacked_installer.h" 27 #include "chrome/browser/extensions/unpacked_installer.h"
27 #include "chrome/browser/extensions/updater/extension_updater.h" 28 #include "chrome/browser/extensions/updater/extension_updater.h"
28 #include "chrome/browser/google/google_util.h" 29 #include "chrome/browser/google/google_util.h"
29 #include "chrome/browser/managed_mode.h" 30 #include "chrome/browser/managed_mode.h"
30 #include "chrome/browser/prefs/pref_service.h" 31 #include "chrome/browser/prefs/pref_service.h"
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 return; 614 return;
614 } 615 }
615 616
616 if (enable_str == "true") { 617 if (enable_str == "true") {
617 extensions::ExtensionPrefs* prefs = extension_service_->extension_prefs(); 618 extensions::ExtensionPrefs* prefs = extension_service_->extension_prefs();
618 if (prefs->DidExtensionEscalatePermissions(extension_id)) { 619 if (prefs->DidExtensionEscalatePermissions(extension_id)) {
619 Browser* browser = browser::FindBrowserWithWebContents( 620 Browser* browser = browser::FindBrowserWithWebContents(
620 web_ui()->GetWebContents()); 621 web_ui()->GetWebContents());
621 extensions::ShowExtensionDisabledDialog( 622 extensions::ShowExtensionDisabledDialog(
622 extension_service_, browser, extension); 623 extension_service_, browser, extension);
624 } else if (prefs->HasUnsupportedRequirements(extension_id)) {
625 // TODO(eriq): i18n
626 ExtensionErrorReporter::GetInstance()->ReportError(
627 ASCIIToUTF16("Cannot enable, not all requirements are met."),
628 true /* be noisy */);
623 } else { 629 } else {
624 extension_service_->EnableExtension(extension_id); 630 extension_service_->EnableExtension(extension_id);
625 } 631 }
626 } else { 632 } else {
627 extension_service_->DisableExtension( 633 extension_service_->DisableExtension(
628 extension_id, Extension::DISABLE_USER_ACTION); 634 extension_id, Extension::DISABLE_USER_ACTION);
629 } 635 }
630 } 636 }
631 637
632 void ExtensionSettingsHandler::HandleEnableIncognitoMessage( 638 void ExtensionSettingsHandler::HandleEnableIncognitoMessage(
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
874 return extension_uninstall_dialog_.get(); 880 return extension_uninstall_dialog_.get();
875 #else 881 #else
876 return NULL; 882 return NULL;
877 #endif // !defined(OS_ANDROID) 883 #endif // !defined(OS_ANDROID)
878 } 884 }
879 885
880 void ExtensionSettingsHandler::InspectExtensionHost(ExtensionHost* host) { 886 void ExtensionSettingsHandler::InspectExtensionHost(ExtensionHost* host) {
881 if (host) 887 if (host)
882 DevToolsWindow::OpenDevToolsWindow(host->render_view_host()); 888 DevToolsWindow::OpenDevToolsWindow(host->render_view_host());
883 } 889 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698