Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 10689084: Merge 143541 - Fix edit profile link in NTP (Closed)

Created:
8 years, 5 months ago by Evan Stade
Modified:
8 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Merge 143541 - Fix edit profile link in NTP currently the manage profile overlay is dimissed when new profile data comes in --- instead, just update the overlay. There's a lot of simplification here which is possible because only one profile (the currently active one) may be managed. BUG=132343 TEST=Sign in to Chrome, click username on NTP, edit the current profile. Review URL: https://chromiumcodereview.appspot.com/10579026 TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -85 lines) Patch
M chrome/browser/resources/options2/browser_options.js View 3 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/resources/options2/manage_profile_overlay.js View 3 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/options2/manage_profile_handler2.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options2/manage_profile_handler2.cc View 2 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Evan Stade
8 years, 5 months ago (2012-07-03 01:32:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698