Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: chrome/browser/ui/panels/test_panel_active_state_observer.h

Issue 10689082: Fix flaky linux panel tests related to active state checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove log msg Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/test_panel_active_state_observer.h
diff --git a/chrome/browser/ui/panels/test_panel_active_state_observer.h b/chrome/browser/ui/panels/test_panel_active_state_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..9fe069f233229de7cb14c64f3fe6e10056340e4b
--- /dev/null
+++ b/chrome/browser/ui/panels/test_panel_active_state_observer.h
@@ -0,0 +1,43 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_PANELS_TEST_PANEL_ACTIVE_STATE_OBSERVER_H_
+#define CHROME_BROWSER_UI_PANELS_TEST_PANEL_ACTIVE_STATE_OBSERVER_H_
+#pragma once
+
+#include "chrome/test/base/ui_test_utils.h"
+
+class Panel;
+
+// Custom notification observer for waiting on panel active state.
+// Modeled after ui_test_utils notification observers.
+class PanelActiveStateObserver : public content::NotificationObserver {
+ public:
+ // Register to listen for panel active state change notifications
+ // for the specified panel to detect a change to the expected active
+ // state.
+ PanelActiveStateObserver(Panel* panel, bool expect_active);
+ virtual ~PanelActiveStateObserver();
+
+ // Wait until the active state has changed to the expected state.
+ void Wait();
+
+ // content::NotificationObserver:
+ virtual void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) OVERRIDE;
+
+ private:
+ bool AtExpectedState();
+ Panel* panel_;
+ bool expect_active_;
+ bool seen_; // true after transition to expected state has been seen
+ bool running_; // indicates whether message loop is running
+ content::NotificationRegistrar registrar_;
+ scoped_refptr<ui_test_utils::MessageLoopRunner> message_loop_runner_;
+
+ DISALLOW_COPY_AND_ASSIGN(PanelActiveStateObserver);
+};
+
+#endif // CHROME_BROWSER_UI_PANELS_TEST_PANEL_ACTIVE_STATE_OBSERVER_H_
« no previous file with comments | « chrome/browser/ui/panels/panel_browsertest.cc ('k') | chrome/browser/ui/panels/test_panel_active_state_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698