Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4073)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 10689071: Deprecate --aura-panels (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_app_browsertest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index a131eb01d328798b9def544971f5dde942057335..f97746430d6fca4075f28502c228503917e4ffaf 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -316,31 +316,6 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenAppShortcutTabPref) {
std::string::npos) << new_browser->app_name_;
}
-IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenAppShortcutPanel) {
- // Load an app with launch.container = 'panel'.
- const Extension* extension_app = NULL;
- ASSERT_NO_FATAL_FAILURE(LoadApp("app_with_panel_container", &extension_app));
-
- CommandLine command_line(CommandLine::NO_PROGRAM);
- command_line.AppendSwitchASCII(switches::kAppId, extension_app->id());
- chrome::startup::IsFirstRun first_run = first_run::IsChromeFirstRun() ?
- chrome::startup::IS_FIRST_RUN : chrome::startup::IS_NOT_FIRST_RUN;
- StartupBrowserCreatorImpl launch(FilePath(), command_line, first_run);
- ASSERT_TRUE(launch.Launch(browser()->profile(), std::vector<GURL>(), false));
-
- // The launch should have created a new browser, with a panel type.
- Browser* new_browser = NULL;
- ASSERT_NO_FATAL_FAILURE(FindOneOtherBrowser(&new_browser));
-
- // Expect an app panel.
- EXPECT_TRUE(new_browser->is_type_panel() && new_browser->is_app());
-
- // The new browser's app_name should include the app's ID.
- EXPECT_NE(
- new_browser->app_name_.find(extension_app->id()),
- std::string::npos) << new_browser->app_name_;
-}
-
#endif // !defined(OS_MACOSX)
#endif // !defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/ui/panels/panel_app_browsertest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698