roll clang 155835:159409

roll clang 155835:159409

First clang roll in a few weeks, so lots of new stuff:

* better 'unused' warnings. Now catches e.g. "AutoLock(&lock);"
* better 'uninitialized' warnings
* template type eliding in diagnostics
* TLS attribute support
* New -Wunused-private-field warning (disabled for now)
* style plugin has better warning for implicit destructors
* method_iterator interface changed back to what it was, update plugin again
* Warn on member variable self assignments

BUG=135207
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145022

[Nico, 2012-06-29 16:12:52]

Let's try this again!

[Nico, 2012-06-29 17:09:45]

+mark, as hans is on vacation

[Mark Mentovai, 2012-06-29 17:42:36]

LGTM

http://codereview.chromium.org/10689041/diff/7001/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

http://codereview.chromium.org/10689041/diff/7001/tools/clang/scripts/update....
tools/clang/scripts/update.sh:11: CLANG_REVISION=159381
Well it’s about time!

[Nico, 2012-06-29 17:43:18]

On 2012/06/29 17:42:36, Mark Mentovai wrote:
> LGTM
> 
>
http://codereview.chromium.org/10689041/diff/7001/tools/clang/scripts/update.sh
> File tools/clang/scripts/update.sh (right):
> 
>
http://codereview.chromium.org/10689041/diff/7001/tools/clang/scripts/update....
> tools/clang/scripts/update.sh:11: CLANG_REVISION=159381
> Well it’s about time!

Looks like it won't work out this time either:
https://code.google.com/p/chromium/issues/detail?id=135207 :-(

[Nico, 2012-06-29 19:36:36]

I changed this to 155409, which seems to fix http://crbug.com/135207 . This
means chrome's clang will be 28 revisions ahead of what we use internally at
google. I've looked through these changes, they all look harmless. matthewbg@
did a smoke test run of 155433 and didn't see issues.

If try trybots are happy with 155409, I'd like to land this.

[Mark Mentovai, 2012-06-29 19:44:49]

LGTM if all of the builds can take it.