Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gfx/render_text.cc

Issue 10689013: Fix tab title fading direction in RTL locales. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: update Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.cc
===================================================================
--- ui/gfx/render_text.cc (revision 144459)
+++ ui/gfx/render_text.cc (working copy)
@@ -854,7 +854,10 @@
bool fade_left = fade_head();
bool fade_right = fade_tail();
// Under RTL, |fade_right| == |fade_head|.
- if (GetTextDirection() == base::i18n::RIGHT_TO_LEFT)
+ // TODO(asvitkine): This is currently not based on GetTextDirection() because
+ // RenderTextWin does not return a direction that's based on
+ // the text content.
+ if (horizontal_alignment() == ALIGN_RIGHT)
std::swap(fade_left, fade_right);
gfx::Rect solid_part = display_rect();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698