chrome/tools/mac_helpers/infoplist_strings_util.mm - Issue 10686005: Add methods to add DataPack from open files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/mac_helpers/infoplist_strings_util.mm

Issue 10686005: Add methods to add DataPack from open files (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/tools/mac_helpers/infoplist_strings_util.mm

diff --git a/chrome/tools/mac_helpers/infoplist_strings_util.mm b/chrome/tools/mac_helpers/infoplist_strings_util.mm

index 051013ba8ca817f608efedcc5c16314455cd4dd0..508c5b754a73e9d7a76b4d76e7b1e6e6cfe32c07 100644

--- a/chrome/tools/mac_helpers/infoplist_strings_util.mm

+++ b/chrome/tools/mac_helpers/infoplist_strings_util.mm

@@ -61,7 +61,7 @@ ui::DataPack* LoadResourceDataPack(const char* dir_path,

if (resource_path) {

FilePath resources_pak_path([resource_path fileSystemRepresentation]);

resource_pack = new ui::DataPack(ui::SCALE_FACTOR_100P);

- bool success = resource_pack->Load(resources_pak_path);

+ bool success = resource_pack->LoadFromPath(resources_pak_path);

if (!success) {

delete resource_pack;

resource_pack = NULL;

« no previous file with comments | « chrome/test/base/chrome_test_suite.cc ('k') | chrome_frame/simple_resource_loader.cc » ('j') | no next file with comments »