Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues()…

base/string_split_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_split.h"
 
 #include "base/utf_string_conversions.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 249 matching lines @@
   EXPECT_THAT(
       results, ElementsAre("un", "deux", "trois", "quatre", "", "", ""));
 }
 
 TEST(StringSplitTest, StringSplitDontTrim) {
   std::vector<std::string> r;
 
   SplitStringDontTrim("   ", '*', &r);
   ASSERT_EQ(1U, r.size());
   EXPECT_EQ(r[0], "   ");
-  r.clear();
 
   SplitStringDontTrim("\t  \ta\t ", '\t', &r);
   ASSERT_EQ(4U, r.size());
   EXPECT_EQ(r[0], "");
   EXPECT_EQ(r[1], "  ");
   EXPECT_EQ(r[2], "a");
   EXPECT_EQ(r[3], " ");
-  r.clear();
 
   SplitStringDontTrim("\ta\t\nb\tcc", '\n', &r);
   ASSERT_EQ(2U, r.size());
   EXPECT_EQ(r[0], "\ta\t");
   EXPECT_EQ(r[1], "b\tcc");
-  r.clear();
 }
 
 TEST(StringSplitTest, SplitStringAlongWhitespace) {
   struct TestData {
     const char* input;
     const size_t expected_result_count;
     const char* output1;
     const char* output2;
   } data[] = {
     { "a",       1, "a",  ""   },
@@ skipping 15 matching lines @@
     SplitStringAlongWhitespace(data[i].input, &results);
     ASSERT_EQ(data[i].expected_result_count, results.size());
     if (data[i].expected_result_count > 0)
       ASSERT_EQ(data[i].output1, results[0]);
     if (data[i].expected_result_count > 1)
       ASSERT_EQ(data[i].output2, results[1]);
   }
 }
 
 }  // namespace base