Issue 10684002: Move NetworkLoginObserver observer management to NetworkLibraryImplBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10684002: Move NetworkLoginObserver observer management to NetworkLibraryImplBase. (Closed)

Created:
8 years, 6 months ago by stevenjb

Modified:
8 years, 5 months ago

Reviewers:
hashimoto, satorux1

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Move NetworkLoginObserver observer management to NetworkLibraryImplBase. BUG=134685 TEST=No more crashes in ~NetowrkLoginObserver Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144500

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -6 lines)			Patch
M	chrome/browser/chromeos/cros/network_library_impl_base.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/network_login_observer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/network_login_observer.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10684002/1

8 years, 5 months ago (2012-06-27 17:40:53 UTC) #3

Change committed as 144500