Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: content/browser/plugin_data_remover_impl.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/test_with_web_server.cc ('k') | webkit/plugins/npapi/plugin_group.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/plugin_data_remover_impl.cc
diff --git a/content/browser/plugin_data_remover_impl.cc b/content/browser/plugin_data_remover_impl.cc
index 51c0c6e4897901ad33ba72195752d1fe1e6268d9..015980c7e41345f692bd758439cbc83c92bd70e4 100644
--- a/content/browser/plugin_data_remover_impl.cc
+++ b/content/browser/plugin_data_remover_impl.cc
@@ -45,13 +45,12 @@ void PluginDataRemover::GetSupportedPlugins(
std::vector<webkit::WebPluginInfo> plugins;
PluginService::GetInstance()->GetPluginInfoArray(
GURL(), kFlashMimeType, allow_wildcard, &plugins, NULL);
- scoped_ptr<Version> min_version(
- Version::GetVersionFromString(kMinFlashVersion));
+ Version min_version(kMinFlashVersion);
for (std::vector<webkit::WebPluginInfo>::iterator it = plugins.begin();
it != plugins.end(); ++it) {
- scoped_ptr<Version> version(
- webkit::npapi::PluginGroup::CreateVersionFromString(it->version));
- if (version.get() && min_version->CompareTo(*version) == -1)
+ Version version;
+ webkit::npapi::PluginGroup::CreateVersionFromString(it->version, &version);
+ if (version.IsValid() && min_version.CompareTo(version) == -1)
supported_plugins->push_back(*it);
}
}
« no previous file with comments | « chrome_frame/test/test_with_web_server.cc ('k') | webkit/plugins/npapi/plugin_group.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698