Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4288)

Unified Diff: chrome/installer/util/install_util.h

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/google_update_settings_unittest.cc ('k') | chrome/installer/util/install_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/install_util.h
diff --git a/chrome/installer/util/install_util.h b/chrome/installer/util/install_util.h
index 682290f35c1d0ec39295ccac7e0d0720035f795f..c3232bd6f2b587153b7e4806f549e2a79beca32f 100644
--- a/chrome/installer/util/install_util.h
+++ b/chrome/installer/util/install_util.h
@@ -39,20 +39,23 @@ class InstallUtil {
BrowserDistribution::Type distribution_type);
// Find the version of Chrome installed on the system by checking the
- // Google Update registry key. Returns the version or NULL if no version is
- // found.
+ // Google Update registry key. Fills |version| with the version or a
+ // default-constructed Version if no version is found.
// system_install: if true, looks for version number under the HKLM root,
// otherwise looks under the HKCU.
- static Version* GetChromeVersion(BrowserDistribution* dist,
- bool system_install);
-
- // Find the last critical update (version) of Chrome. Returns the version or
- // NULL if no such version is found. A critical update is a specially flagged
- // version (by Google Update) that contains an important security fix.
+ static void GetChromeVersion(BrowserDistribution* dist,
+ bool system_install,
+ Version* version);
+
+ // Find the last critical update (version) of Chrome. Fills |version| with the
+ // version or a default-constructed Version if no version is found. A critical
+ // update is a specially flagged version (by Google Update) that contains an
+ // important security fix.
// system_install: if true, looks for version number under the HKLM root,
// otherwise looks under the HKCU.
- static Version* GetCriticalUpdateVersion(BrowserDistribution* dist,
- bool system_install);
+ static void GetCriticalUpdateVersion(BrowserDistribution* dist,
+ bool system_install,
+ Version* version);
// This function checks if the current OS is supported for Chromium.
static bool IsOSSupported();
« no previous file with comments | « chrome/installer/util/google_update_settings_unittest.cc ('k') | chrome/installer/util/install_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698