chrome/browser/extensions/crx_installer.cc - Issue 10683005: Remove two deprecated methods from base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ... Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 17b919b1a02cef3074bb908945391aaf9687c91a..11dad9227ad2cb7137c866f1152ae3edfa242bc7 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -473,9 +473,8 @@ void CrxInstaller::CompleteInstall() {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

if (!current_version_.empty()) {

- scoped_ptr<Version> current_version(

- Version::GetVersionFromString(current_version_));

- if (current_version->CompareTo(*(extension_->version())) > 0) {

+ Version current_version(current_version_);

+ if (current_version.CompareTo(*(extension_->version())) > 0) {

ReportFailureFromFileThread(

CrxInstallerError(

l10n_util::GetStringUTF16(IDS_EXTENSION_CANT_DOWNGRADE_VERSION)));