Moved CrxInstaller and CrxInstallerError into extensions namespace

Moved CrxInstaller and CrxInstallerError into extensions namespace

BUG=134756, 117261
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148244

[Devlin, 2012-07-03 17:07:47]

Simple refactor touching multiple parts of the codebase; please review if
possible. :)

[Mattias Nissler (ping if slow), 2012-07-03 17:31:10]

chrome/browser/policy LGTM

Adding joaodasilva@ and asargent@ FYI

[not at google - send to devlin, 2012-07-04 01:13:31]

extensions/ and performance_monitor/ lgtm

https://chromiumcodereview.appspot.com/10683003/diff/4025/chrome/browser/exte...
File chrome/browser/extensions/crx_installer.cc (right):

https://chromiumcodereview.appspot.com/10683003/diff/4025/chrome/browser/exte...
chrome/browser/extensions/crx_installer.cc:68: namespace extensions {
I think that usually the namespace would surround the anonymous namespaces too,
since you'd usually want for those to benefit from having access to e.g.
Extension rather than extensions::Extension (not that it matters in this case,
but a good pattern anyway).

[Joao da Silva, 2012-07-04 06:40:55]

Can you submit a couple of try jobs?

[Aaron Boodman, 2012-07-04 18:10:42]

The rule is try jobs or cq. Devlin is not a committer so he can only use
cq.

- a, via phone
On Jul 3, 2012 11:40 PM, <joaodasilva@chromium.org> wrote:

> Can you submit a couple of try jobs?
>
>
https://chromiumcodereview.**appspot.com/10683003/<https://chromiumcodereview...
>

[Aaron Boodman, 2012-07-04 18:51:31]

Sorry, that wasn't clear. What I meant was: as Devlin is not a
committer, there is guaranteed to be a try run before landing.

- a

On Wed, Jul 4, 2012 at 11:10 AM, Aaron Boodman <aa@chromium.org> wrote:
> The rule is try jobs or cq. Devlin is not a committer so he can only use cq.
>
> - a, via phone
>
> On Jul 3, 2012 11:40 PM, <joaodasilva@chromium.org> wrote:
>>
>> Can you submit a couple of try jobs?
>>
>> https://chromiumcodereview.appspot.com/10683003/

[Evan Stade, 2012-07-09 20:29:53]

CQ doesn't run all tests, it's not good as a replacement for try jobs. I've
submitted via the CQ before without try jobs, had it successfully land and then
had to roll back because it broke some tests that the CQ doesn't run.

[sky, 2012-07-16 23:10:43]

LGTM

[Devlin, 2012-07-17 15:51:40]

+asargent for c/b/component_updater

[asargent_no_longer_on_chrome, 2012-07-19 17:17:18]

LGTM

[Devlin, 2012-07-23 16:28:55]

+darin for c/b/automation

[darin (slow to review), 2012-07-23 23:24:50]

LGTM for chrome/browser/automation.  For trivial changes like this, feel free to
TBR in the future.

[commit-bot: I haz the power, 2012-07-24 17:43:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10683003/2...

[commit-bot: I haz the power, 2012-07-24 18:10:05]

Try job failure for 10683003-29001 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-07-24 19:10:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10683003/2...

[commit-bot: I haz the power, 2012-07-24 20:44:41]

Failed to apply patch for chrome/browser/extensions/extension_service.h:
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/extension_service.h
Hunk #2 FAILED at 66.
Hunk #3 succeeded at 86 with fuzz 1 (offset -3 lines).
Hunk #4 succeeded at 111 (offset -3 lines).
Hunk #5 succeeded at 317 (offset -3 lines).
1 out of 5 hunks FAILED -- saving rejects to file
chrome/browser/extensions/extension_service.h.rej

[commit-bot: I haz the power, 2012-07-24 21:20:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10683003/3...

[commit-bot: I haz the power, 2012-07-24 23:20:34]

Change committed as 148244