Issue 10682013: Properly fix liveedit heap traversal bug with write barrier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10682013: Properly fix liveedit heap traversal bug with write barrier (Closed)

Created:
8 years, 6 months ago by Peter Rybin

Modified:
8 years, 5 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Properly fix liveedit heap traversal bug with write barrier Committed: https://code.google.com/p/v8/source/detail?r=11960

Patch Set 1 #

Patch Set 2 : style #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	src/liveedit.cc	View	1	3 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

I'm sorry for double review. In the previous change ( http://codereview.chromium.org/10639006/ ) I managed to ...

8 years, 6 months ago (2012-06-27 00:07:17 UTC) #1

Peter Rybin

8 years, 5 months ago (2012-07-01 22:09:17 UTC) #2

TBR=erik.corry@gmail.com

This change is only adding "Handle" to pointers over already reviewed
http://codereview.chromium.org/10639006

Hope you don't mind I TBR it.



On 2012/06/27 00:07:17, Peter Rybin wrote:
> I'm sorry for double review.
> 
> In the previous change ( http://codereview.chromium.org/10639006/ ) I managed
to
> keep pointers raw in the presence of explicit call to GC.
> 
> This change only adds Handles to the original one. Plus a missing test skip
> added for mips.

Expand Messages | Collapse Messages