Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 10682007: Move PendingExtensionManager and PendingExtensionInfo into extensions namespace (Closed)

Created:
8 years, 5 months ago by Devlin
Modified:
8 years, 4 months ago
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, tim (not reviewing)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move PendingExtensionManager and PendingExtensionInfo into extensions namespace BUG=134744, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148654

Patch Set 1 : #

Patch Set 2 : Merged with latest master #

Patch Set 3 : Updated with latest master #

Patch Set 4 : Latest master #

Patch Set 5 : Latest master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -49 lines) Patch
M chrome/browser/extensions/extension_management_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 4 6 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 9 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/extensions/pending_extension_info.h View 1 2 5 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/extensions/pending_extension_info.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.h View 1 2 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_service.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_service.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_app_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Devlin
Please review when you get a chance: zea - chrome/browser/sync miket - chrome/browser/extensions Thanks in ...
8 years, 5 months ago (2012-07-06 22:20:19 UTC) #1
Nicolas Zea
sync LGTM
8 years, 5 months ago (2012-07-09 17:55:10 UTC) #2
Devlin
-miket (vacation?) +asargent Please review c/b/extensions
8 years, 4 months ago (2012-07-26 18:01:17 UTC) #3
asargent_no_longer_on_chrome
LGTM
8 years, 4 months ago (2012-07-26 19:47:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10682007/18001
8 years, 4 months ago (2012-07-26 21:03:47 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-26 23:39:46 UTC) #6
Change committed as 148654

Powered by Google App Engine
This is Rietveld 408576698