Add ppapi interface for setting crash data

This adds an interface for setting crash data from a plugin. It also provides an implementation for setting crash URLs.

BUG=134176
TEST=Added test case to sanity check API call. Also hooked up to flash and produced a crash and checked that the report included the document url (http://crash/reportdetail?reportid=1719cae3a745f633)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144516

[yzshen1, 2012-06-26 22:44:27]

LGTM with only a few nits.

Thanks a lot for doing this!

http://codereview.chromium.org/10681006/diff/2001/ppapi/proxy/plugin_proxy_de...
File ppapi/proxy/plugin_proxy_delegate.h (right):

http://codereview.chromium.org/10681006/diff/2001/ppapi/proxy/plugin_proxy_de...
ppapi/proxy/plugin_proxy_delegate.h:30: // Set the active url which is reported
by breakpad.
nit:
- Set -> Sets
- I think you can forward declare GURL.

http://codereview.chromium.org/10681006/diff/2001/ppapi/thunk/ppb_flash_api.h
File ppapi/thunk/ppb_flash_api.h (right):

http://codereview.chromium.org/10681006/diff/2001/ppapi/thunk/ppb_flash_api.h...
ppapi/thunk/ppb_flash_api.h:48: virtual PP_Bool SetCrashData(PP_Instance
instance,
nit: none of the subclasses need |instance|, we could remove it.

[raymes, 2012-06-26 23:16:56]

http://codereview.chromium.org/10681006/diff/2001/ppapi/proxy/plugin_proxy_de...
File ppapi/proxy/plugin_proxy_delegate.h (right):

http://codereview.chromium.org/10681006/diff/2001/ppapi/proxy/plugin_proxy_de...
ppapi/proxy/plugin_proxy_delegate.h:30: // Set the active url which is reported
by breakpad.
On 2012/06/26 22:44:28, yzshen1 wrote:
> nit:
> - Set -> Sets
> - I think you can forward declare GURL.

Done.

[commit-bot: I haz the power, 2012-06-26 23:19:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/10681006/1021

[commit-bot: I haz the power, 2012-06-26 23:19:11]

Presubmit check for 10681006-1021 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/ppapi_plugin

Presubmit checks took 2.8s to calculate.

[raymes, 2012-06-26 23:20:26]

+brettw for content/ OWNERS

[brettw, 2012-06-26 23:46:45]

http://codereview.chromium.org/10681006/diff/1021/ppapi/proxy/plugin_proxy_de...
File ppapi/proxy/plugin_proxy_delegate.h (right):

http://codereview.chromium.org/10681006/diff/1021/ppapi/proxy/plugin_proxy_de...
ppapi/proxy/plugin_proxy_delegate.h:31: virtual void SetActiveURL(const GURL&
url) = 0;
What's the reason for using GURL here? I'm not sure we want the proxy to depend
on GURL, and this could just as easily be a string.

[raymes, 2012-06-26 23:50:39]

No reason, I was just mirroring the interface to breakpad. I'll make
it a string and only the delegate will depend on GURL.

On Tue, Jun 26, 2012 at 4:46 PM,  <brettw@chromium.org> wrote:
>
>
http://codereview.chromium.org/10681006/diff/1021/ppapi/proxy/plugin_proxy_de...
> File ppapi/proxy/plugin_proxy_delegate.h (right):
>
>
http://codereview.chromium.org/10681006/diff/1021/ppapi/proxy/plugin_proxy_de...
> ppapi/proxy/plugin_proxy_delegate.h:31: virtual void SetActiveURL(const
> GURL& url) = 0;
> What's the reason for using GURL here? I'm not sure we want the proxy to
> depend on GURL, and this could just as easily be a string.
>
> http://codereview.chromium.org/10681006/

[raymes, 2012-06-27 16:35:55]

http://codereview.chromium.org/10681006/diff/1021/ppapi/proxy/plugin_proxy_de...
File ppapi/proxy/plugin_proxy_delegate.h (right):

http://codereview.chromium.org/10681006/diff/1021/ppapi/proxy/plugin_proxy_de...
ppapi/proxy/plugin_proxy_delegate.h:31: virtual void SetActiveURL(const GURL&
url) = 0;
On 2012/06/26 23:46:46, brettw wrote:
> What's the reason for using GURL here? I'm not sure we want the proxy to
depend
> on GURL, and this could just as easily be a string.

Done.

[brettw, 2012-06-27 16:39:36]

lgtm

[commit-bot: I haz the power, 2012-06-27 17:53:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/10681006/11001

[commit-bot: I haz the power, 2012-06-27 19:31:00]

Change committed as 144516