Added sorting functionality to HTML tables on coverage dashboard.

Added sorting functionality to HTML tables on coverage dashboard.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146014

[John Grabowski, 2012-06-26 21:45:29]

https://chromiumcodereview.appspot.com/10681003/diff/2001/tools/code_coverage...
File tools/code_coverage/croc_html.py (right):

https://chromiumcodereview.appspot.com/10681003/diff/2001/tools/code_coverage...
tools/code_coverage/croc_html.py:196: caption = None
This is odd.  caption is a param, which you force to a specific value.  Maybe
better to make the caller pass None to do what you want?

https://chromiumcodereview.appspot.com/10681003/diff/2001/tools/code_coverage...
File tools/code_coverage/sorttable.js (right):

https://chromiumcodereview.appspot.com/10681003/diff/2001/tools/code_coverage...
tools/code_coverage/sorttable.js:1: /*
This needs to go in a third_party directory.
See Google Rules for 3rd party code.

[pshenoy, 2012-06-29 18:23:07]

https://chromiumcodereview.appspot.com/10681003/diff/2001/tools/code_coverage...
File tools/code_coverage/croc_html.py (right):

https://chromiumcodereview.appspot.com/10681003/diff/2001/tools/code_coverage...
tools/code_coverage/croc_html.py:196: caption = None
On 2012/06/26 21:45:29, John Grabowski wrote:
> This is odd.  caption is a param, which you force to a specific value.  Maybe
> better to make the caller pass None to do what you want?

Sorry. I did this for testing purpose and forgot to remove. Done.

https://chromiumcodereview.appspot.com/10681003/diff/2001/tools/code_coverage...
File tools/code_coverage/sorttable.js (right):

https://chromiumcodereview.appspot.com/10681003/diff/2001/tools/code_coverage...
tools/code_coverage/sorttable.js:1: /*
On 2012/06/26 21:45:29, John Grabowski wrote:
> This needs to go in a third_party directory.
> See Google Rules for 3rd party code.

Done.

[John Grabowski, 2012-07-10 17:37:14]

LGTM

http://codereview.chromium.org/10681003/diff/7001/tools/code_coverage/croc_ht...
File tools/code_coverage/croc_html.py (right):

http://codereview.chromium.org/10681003/diff/7001/tools/code_coverage/croc_ht...
tools/code_coverage/croc_html.py:412: copy_files = [
since only one file each, can you
copy_files = ['croc.css']
?

(for both)

[pshenoy, 2012-07-10 18:02:22]

http://codereview.chromium.org/10681003/diff/7001/tools/code_coverage/croc_ht...
File tools/code_coverage/croc_html.py (right):

http://codereview.chromium.org/10681003/diff/7001/tools/code_coverage/croc_ht...
tools/code_coverage/croc_html.py:412: copy_files = [
On 2012/07/10 17:37:14, John Grabowski wrote:
> since only one file each, can you
> copy_files = ['croc.css']
> ?
> 
> (for both)
I thought it is a good idea to maintain a separate list for third party files in
case we add more third party files in future. What do you think?

[John Grabowski, 2012-07-10 18:08:19]

http://codereview.chromium.org/10681003/diff/7001/tools/code_coverage/croc_ht...
File tools/code_coverage/croc_html.py (right):

http://codereview.chromium.org/10681003/diff/7001/tools/code_coverage/croc_ht...
tools/code_coverage/croc_html.py:412: copy_files = [
On 2012/07/10 18:02:22, pshenoy wrote:
> On 2012/07/10 17:37:14, John Grabowski wrote:
> > since only one file each, can you
> > copy_files = ['croc.css']
> > ?
> > 
> > (for both)
> I thought it is a good idea to maintain a separate list for third party files
in
> case we add more third party files in future. What do you think?

that's fine but still do this

copy_files = ['croc.css']
third_party_files = ['sorttable.js']

No need to = [
  'on three lines'
]

[pshenoy, 2012-07-10 18:22:23]

http://codereview.chromium.org/10681003/diff/7001/tools/code_coverage/croc_ht...
File tools/code_coverage/croc_html.py (right):

http://codereview.chromium.org/10681003/diff/7001/tools/code_coverage/croc_ht...
tools/code_coverage/croc_html.py:412: copy_files = [
On 2012/07/10 18:08:19, John Grabowski wrote:
> On 2012/07/10 18:02:22, pshenoy wrote:
> > On 2012/07/10 17:37:14, John Grabowski wrote:
> > > since only one file each, can you
> > > copy_files = ['croc.css']
> > > ?
> > > 
> > > (for both)
> > I thought it is a good idea to maintain a separate list for third party
files
> in
> > case we add more third party files in future. What do you think?
> 
> that's fine but still do this
> 
> copy_files = ['croc.css']
> third_party_files = ['sorttable.js']
> 
> No need to = [
>   'on three lines'
> ]
> 

Done.

[commit-bot: I haz the power, 2012-07-10 18:22:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pshenoy@chromium.org/10681003/14001

[commit-bot: I haz the power, 2012-07-10 19:33:43]

Try job failure for 10681003-14001 (retry) (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-10 19:43:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pshenoy@chromium.org/10681003/14001

[commit-bot: I haz the power, 2012-07-10 21:19:09]

Try job failure for 10681003-14001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-07-10 21:22:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pshenoy@chromium.org/10681003/14001

[commit-bot: I haz the power, 2012-07-10 23:07:24]

Try job failure for 10681003-14001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-07-10 23:27:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pshenoy@chromium.org/10681003/14001

[commit-bot: I haz the power, 2012-07-11 00:58:25]

Change committed as 146014