Issue 10680013: Remove unused fields found by clang's new Wunused-private-fields.

Issue 10680013: Remove unused fields found by clang's new Wunused-private-fields. (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 5 months ago

Reviewers:
Mark Mentovai, tony, dmichael (off chromium)

CC:
chromium-reviews, amit, kinuko+watch, dcaiafa+watch_chromium.org, ncarter (slow), jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, tim (not reviewing), jochen+watch-content_chromium.org, wez+watch_chromium.org, Raghu Simha, sanjeevr, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, akalin, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused fields found by clang's new Wunused-private-fields. Test file edition. BUG=none TEST=none TBR=remaining owners Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144464

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -43 lines)			Patch
M	chrome/browser/locale_tests_browsertest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/managed_mode_unittest.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_database_helper.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_database_helper.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_file_system_helper.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_file_system_helper.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_local_storage_helper.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_local_storage_helper.cc	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_quota_helper.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/common/gpu/media/video_decode_accelerator_unittest.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	ipc/ipc_sync_channel_unittest.cc	View	1 2	4 chunks	+3 lines, -3 lines	0 comments	Download
M	net/socket/socket_test_util.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/examples/flash_topmost/flash_topmost.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	remoting/protocol/connection_tester.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/protocol/connection_tester.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/internal_api/public/sessions/sync_session_snapshot.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/internal_api/public/sessions/sync_session_snapshot.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/fileapi/file_system_test_helper.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/fileapi/obfuscated_file_util_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/quota/quota_temporary_storage_evictor_unittest.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	webkit/tools/test_shell/notification_presenter.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/notification_presenter.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/10680013/diff/2001/chrome/browser/mock_browsing_data_local_storage_helper.cc File chrome/browser/mock_browsing_data_local_storage_helper.cc (right): http://codereview.chromium.org/10680013/diff/2001/chrome/browser/mock_browsing_data_local_storage_helper.cc#newcode12 chrome/browser/mock_browsing_data_local_storage_helper.cc:12: : BrowsingDataLocalStorageHelper(profile) { Fix the indentation here while ...

8 years, 5 months ago (2012-06-27 14:53:12 UTC) #3

Nico

Thanks! http://codereview.chromium.org/10680013/diff/2001/chrome/browser/mock_browsing_data_local_storage_helper.cc File chrome/browser/mock_browsing_data_local_storage_helper.cc (right): http://codereview.chromium.org/10680013/diff/2001/chrome/browser/mock_browsing_data_local_storage_helper.cc#newcode12 chrome/browser/mock_browsing_data_local_storage_helper.cc:12: : BrowsingDataLocalStorageHelper(profile) { On 2012/06/27 14:53:12, Mark Mentovai ...

8 years, 5 months ago (2012-06-27 14:57:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10680013/4002

8 years, 5 months ago (2012-06-27 14:58:18 UTC) #5

Change committed as 144464

Expand Messages | Collapse Messages