Invoke PluginImplementedObjectDestroyed for ppp_class deallocate

ppapi/proxy/ppp_class_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppp_class_proxy.h"
 
 #include "ppapi/c/dev/ppb_var_deprecated.h"
 #include "ppapi/c/dev/ppp_class_deprecated.h"
 #include "ppapi/c/pp_var.h"
 #include "ppapi/proxy/dispatcher.h"
@@ skipping 324 matching lines @@
   PP_Var* args = arg_vector.Get(dispatcher(), &arg_count);
   result.Return(dispatcher(), CallWhileUnlocked(
       ToPPPClass(ppp_class)->Construct,
       ToUserData(object), arg_count, args, exception.OutParam(dispatcher())));
 }
 
 void PPP_Class_Proxy::OnMsgDeallocate(int64 ppp_class, int64 object) {
   if (!ValidateUserData(ppp_class, object, NULL))
     return;
   CallWhileUnlocked(ToPPPClass(ppp_class)->Deallocate, ToUserData(object));
+  PluginGlobals::Get()->plugin_var_tracker()->PluginImplementedObjectDestroyed(

[brettw, 2012/06/27 05:22:38]

Actually, I'd feel slightly better if this was moved to before the Deallocate
call. Just in case we get some weird reentrancy in there.

[Josh Horwich, 2012/06/27 17:03:55]

Done.

+      ToUserData(object));
 }
 
 bool PPP_Class_Proxy::ValidateUserData(int64 ppp_class, int64 class_data,
                                        SerializedVarOutParam* exception) {
   if (!PluginGlobals::Get()->plugin_var_tracker()->ValidatePluginObjectCall(
           ToPPPClass(ppp_class), ToUserData(class_data))) {
     // Set the exception. This is so the caller will know about the error and
     // also that we won't assert that somebody forgot to call OutParam on the
     // output parameter. Although this exception of "1" won't be very useful
     // this shouldn't happen in normal usage, only when the renderer is being
     // malicious.
     if (exception)
       *exception->OutParam(dispatcher()) = PP_MakeInt32(1);
     return false;
   }
   return true;
 }
 
 }  // namespace proxy
 }  // namespace ppapi