Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 10677015: Add INTERNAL annotation to namespaces in IDL (Closed)

Created:
8 years, 6 months ago by Gaurav
Modified:
8 years, 4 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add INTERNAL annotation to namespaces in IDL BUG=129311 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149553

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M tools/json_schema_compiler/idl_schema.py View 1 2 4 chunks +10 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/idl_schema_test.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/test/idl_basics.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Gaurav
Added annotation "internal" for namespaces to the IDL files.
8 years, 5 months ago (2012-06-28 21:52:45 UTC) #1
asargent_no_longer_on_chrome
LGTM
8 years, 5 months ago (2012-06-29 00:19:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/10677015/1
8 years, 5 months ago (2012-06-29 00:23:50 UTC) #3
commit-bot: I haz the power
Try job failure for 10677015-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-06-29 01:10:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/10677015/1
8 years, 5 months ago (2012-07-12 23:49:48 UTC) #5
commit-bot: I haz the power
Failed to apply patch for tools/json_schema_compiler/idl_schema.py: While running patch -p1 --forward --force; patching file tools/json_schema_compiler/idl_schema.py ...
8 years, 5 months ago (2012-07-12 23:49:52 UTC) #6
Mihai Parparita -not on Chrome
Gaurav, it looks like you'll need to rebaseline this patch and reupload it for the ...
8 years, 5 months ago (2012-07-12 23:50:35 UTC) #7
Gaurav
Thanks mihalp. I will do that On Thu, Jul 12, 2012 at 4:50 PM, <mihaip@chromium.org> ...
8 years, 5 months ago (2012-07-13 00:58:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/10677015/12001
8 years, 5 months ago (2012-07-24 01:17:39 UTC) #9
commit-bot: I haz the power
Failed to apply patch for tools/json_schema_compiler/idl_schema.py: While running patch -p1 --forward --force; patching file tools/json_schema_compiler/idl_schema.py ...
8 years, 5 months ago (2012-07-24 01:17:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/10677015/16001
8 years, 4 months ago (2012-08-01 23:58:25 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 01:17:28 UTC) #12
Change committed as 149553

Powered by Google App Engine
This is Rietveld 408576698