Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: runtime/vm/gc_marker.cc

Issue 10675010: - Premark vm_isolate objects to avoid having to test for them (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/gc_marker.cc
===================================================================
--- runtime/vm/gc_marker.cc (revision 9135)
+++ runtime/vm/gc_marker.cc (working copy)
@@ -168,13 +168,8 @@
return;
}
- uword raw_addr = RawObject::ToAddr(raw_obj);
- // TODO(iposva): Premark vm_isolate objects, to avoid this extra check here.
- if (vm_heap_->Contains(raw_addr)) {
- return;
- }
// TODO(iposva): merge old and code spaces.
- ASSERT(page_space_->Contains(raw_addr));
+ ASSERT(page_space_->Contains(RawObject::ToAddr(raw_obj)));
MarkAndPush(raw_obj);
}
@@ -191,6 +186,9 @@
if (!raw_obj->IsHeapObject()) {
return false;
}
+ if (raw_obj == Object::null()) {
+ return true;
+ }
if (!raw_obj->IsOldObject()) {
return false;
}
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698