Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 10675007: Move each permission classes to its own files in extensions/permissions (Closed)

Created:
8 years, 6 months ago by Peng
Modified:
8 years, 6 months ago
Reviewers:
miket_OOO, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, mihaip-chromium-reviews_chromium.org, jeremya+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, estade+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move each permission classes to its own files in extensions/permissions and rename classes from ExtensionPermission* to extensions::Permission* This CL replaces CL 10649003 TBR=estade BUG=133049 TEST=unit_tests & browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144408

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix review issues #

Patch Set 3 : Fix the indentation #

Patch Set 4 : Update #

Patch Set 5 : Fix build issues #

Patch Set 6 : Fix build issue on Windows #

Patch Set 7 : Rebase on HEAD #

Patch Set 8 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2161 lines, -3166 lines) Patch
M chrome/browser/background/background_application_list_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/background/background_application_list_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_tab_permission_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 1 2 3 7 chunks +20 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers.cc View 4 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/bundle_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_api.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_info_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_map_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_preference_api.cc View 9 chunks +24 lines, -22 lines 0 comments Download
M chrome/browser/extensions/extension_preference_helpers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_preference_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 12 chunks +29 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 14 chunks +34 lines, -30 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 12 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater.h View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 6 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 7 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/settings/settings_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/content_settings_handler2.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.h View 14 chunks +26 lines, -26 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 4 5 6 7 27 chunks +40 lines, -39 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_messages.cc View 1 2 3 4 3 chunks +7 lines, -5 lines 0 comments Download
D chrome/common/extensions/extension_permission_set.h View 1 2 3 4 5 6 1 chunk +0 lines, -472 lines 0 comments Download
D chrome/common/extensions/extension_permission_set.cc View 1 2 3 4 5 6 1 chunk +0 lines, -952 lines 0 comments Download
D chrome/common/extensions/extension_permission_set_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1157 lines 0 comments Download
M chrome/common/extensions/features/permission_feature.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/permissions/api_permission.h View 1 2 3 4 5 6 1 chunk +162 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/api_permission.cc View 1 2 3 4 5 6 1 chunk +183 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permission_message.h View 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permission_message.cc View 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permission_set.h View 1 chunk +205 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permission_set.cc View 1 2 3 4 5 6 1 chunk +651 lines, -0 lines 0 comments Download
A + chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 5 6 51 chunks +230 lines, -227 lines 0 comments Download
A chrome/common/extensions/permissions/permissions_info.h View 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/common/extensions/permissions/permissions_info.cc View 1 1 chunk +84 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 1 2 3 4 4 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Peng
Hi Estade and Miket, Because account issue, I have to recreate a new CL to ...
8 years, 6 months ago (2012-06-26 23:13:54 UTC) #1
miket_OOO
A couple comments. LGTM. https://chromiumcodereview.appspot.com/10675007/diff/1/chrome/common/extensions/permissions/permissions_info.cc File chrome/common/extensions/permissions/permissions_info.cc (right): https://chromiumcodereview.appspot.com/10675007/diff/1/chrome/common/extensions/permissions/permissions_info.cc#newcode10 chrome/common/extensions/permissions/permissions_info.cc:10: // PermissionsInfo This comment is ...
8 years, 6 months ago (2012-06-26 23:23:43 UTC) #2
Peng
https://chromiumcodereview.appspot.com/10675007/diff/1/chrome/common/extensions/permissions/permissions_info.cc File chrome/common/extensions/permissions/permissions_info.cc (right): https://chromiumcodereview.appspot.com/10675007/diff/1/chrome/common/extensions/permissions/permissions_info.cc#newcode10 chrome/common/extensions/permissions/permissions_info.cc:10: // PermissionsInfo On 2012/06/26 23:23:44, miket wrote: > This ...
8 years, 6 months ago (2012-06-26 23:32:35 UTC) #3
miket_OOO
> chrome/renderer/chrome_render_view_observer.cc:501: > extension->HasAPIPermission(extensions::APIPermission::kExperimental)); > On 2012/06/26 23:23:44, miket wrote: > > Whitespace! (Sorry to ...
8 years, 6 months ago (2012-06-26 23:39:49 UTC) #4
Peng
https://chromiumcodereview.appspot.com/10675007/diff/1/chrome/renderer/chrome_render_view_observer.cc File chrome/renderer/chrome_render_view_observer.cc (right): https://chromiumcodereview.appspot.com/10675007/diff/1/chrome/renderer/chrome_render_view_observer.cc#newcode501 chrome/renderer/chrome_render_view_observer.cc:501: extension->HasAPIPermission(extensions::APIPermission::kExperimental)); On 2012/06/26 23:32:35, Peng wrote: > On 2012/06/26 ...
8 years, 6 months ago (2012-06-26 23:42:53 UTC) #5
miket_OOO
> Done. AWESOME!!!!
8 years, 6 months ago (2012-06-26 23:43:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/8001
8 years, 6 months ago (2012-06-26 23:44:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/11002
8 years, 6 months ago (2012-06-27 00:49:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/1072
8 years, 6 months ago (2012-06-27 01:12:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/6076
8 years, 6 months ago (2012-06-27 01:43:12 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/permissions/permission_set_unittest.cc: While running patch -p1 --forward --force; A chrome/common/extensions/permissions patching ...
8 years, 6 months ago (2012-06-27 02:43:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/14005
8 years, 6 months ago (2012-06-27 03:05:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/14005
8 years, 6 months ago (2012-06-27 03:16:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/21001
8 years, 6 months ago (2012-06-27 03:23:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/21001
8 years, 6 months ago (2012-06-27 03:42:21 UTC) #15
commit-bot: I haz the power
Try job failure for 10675007-21001 (retry) on mac_rel for step "browser_tests" (clobber build). It's a ...
8 years, 6 months ago (2012-06-27 04:34:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10675007/21001
8 years, 6 months ago (2012-06-27 04:39:24 UTC) #17
commit-bot: I haz the power
8 years, 6 months ago (2012-06-27 06:27:09 UTC) #18
Change committed as 144408

Powered by Google App Engine
This is Rietveld 408576698