Issue 10673011: sas.dll is not included to Windows 8 SDK. Use one from from Windows 7 SDK instead.

Issue 10673011: sas.dll is not included to Windows 8 SDK. Use one from from Windows 7 SDK instead. (Closed)

Created:
8 years, 6 months ago by alexeypa (please no reviews)

Modified:
8 years, 5 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
dharani1, chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sas.dll is not included to Windows 8 SDK. Use one from from Windows 7 SDK instead. BUG=134509 TEST=src/remoting.gyp:remoting_host_installation is buildable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144507

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View	3 chunks	+3 lines, -3 lines	1 comment	Download
M	remoting/candle_and_light.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/remoting.gyp	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

Please take a look. platformsdk_path% was used solely by src/remoting. This CL changes it to ...

8 years, 6 months ago (2012-06-26 23:28:37 UTC) #1

cpu_(ooo_6.6-7.5)

Thanks for taking care of this. Hard to believe nobody else uses platformsdk_path. lgtm. http://codereview.chromium.org/10673011/diff/1/build/common.gypi ...

8 years, 6 months ago (2012-06-27 02:05:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10673011/1

8 years, 5 months ago (2012-06-27 18:06:29 UTC) #3

alexeypa (please no reviews)

8 years, 5 months ago (2012-06-27 19:35:28 UTC) #5

+dharani@

I believe this CL is safe but I agree it has potential to break things. Adding
dharani@ for awareness.

Expand Messages | Collapse Messages