Don't rely on undefined macro behaviour in unit tests.

Don't rely on undefined macro behaviour in unit tests.

Ensure that the macros properly adhere to C++03 16.1.4's requirements
for evaluation.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144361

[Ryan Sleevi, 2012-06-26 22:49:33]

jar: I think you'll appreciate this C++ edge case. The discussion around it was
mostly internal (Corp bug tracker, Corp G+), but the change that made it to the
header (and not the unit test) was http://crrev.com/138755

[jar (doing other things), 2012-06-26 23:02:40]

Amazing piece of code (I can't believe folks wrote this code historically with a
straight face).


Tiny nit, and LGTM.

http://codereview.chromium.org/10673010/diff/1/base/threading/thread_checker_...
File base/threading/thread_checker_unittest.cc (right):

http://codereview.chromium.org/10673010/diff/1/base/threading/thread_checker_...
base/threading/thread_checker_unittest.cc:14: #if (!defined(NDEBUG) ||
defined(DCHECK_ALWAYS_ON))
nit: You don't need the outer parens

[commit-bot: I haz the power, 2012-06-26 23:03:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10673010/4001

[commit-bot: I haz the power, 2012-06-26 23:14:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10673010/4003

[commit-bot: I haz the power, 2012-06-27 00:05:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10673010/9003

[commit-bot: I haz the power, 2012-06-27 01:39:53]

Change committed as 144361