Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10673005: Removes unused thumbnail and favicon fields from PageUsageData. (Closed)

Created:
8 years, 6 months ago by rohitrao (ping after 24h)
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removes unused thumbnail and favicon fields from PageUsageData. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -81 lines) Patch
M chrome/browser/history/page_usage_data.h View 3 chunks +1 line, -55 lines 0 comments Download
M chrome/browser/history/page_usage_data.cc View 2 chunks +1 line, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rohitrao (ping after 24h)
Hi Scott, I was looking at removing SkBitmaps from chrome/browser/history and noticed these two in ...
8 years, 6 months ago (2012-06-26 21:27:02 UTC) #1
sky
I can't think of any reason to keep them around. LGTM
8 years, 6 months ago (2012-06-26 21:57:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10673005/1
8 years, 6 months ago (2012-06-26 21:59:25 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-26 23:14:15 UTC) #4
Change committed as 144316

Powered by Google App Engine
This is Rietveld 408576698