Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 106723002: Fix loop side-effects of deoptimizing loops with a nested live OSR loop. (Closed)

Created:
7 years ago by Toon Verwaest
Modified:
7 years ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Fix loop side-effects of deoptimizing loops with a nested live OSR loop. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18263

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M src/hydrogen-gvn.cc View 1 2 chunks +9 lines, -5 lines 0 comments Download
A + test/mjsunit/regress/regress-context-osr.js View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
7 years ago (2013-12-05 17:30:47 UTC) #1
titzer
https://chromiumcodereview.appspot.com/106723002/diff/20001/src/hydrogen-gvn.cc File src/hydrogen-gvn.cc (right): https://chromiumcodereview.appspot.com/106723002/diff/20001/src/hydrogen-gvn.cc#newcode409 src/hydrogen-gvn.cc:409: if (block->IsLoopHeader()) { Can you turn this whole thing ...
7 years ago (2013-12-05 17:52:08 UTC) #2
Toon Verwaest
Addressed comments, minus the more nested loops. Those would take too long with the current ...
7 years ago (2013-12-05 18:22:56 UTC) #3
titzer
LGTM
7 years ago (2013-12-05 18:29:38 UTC) #4
Toon Verwaest
7 years ago (2013-12-05 18:31:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18263.

Powered by Google App Engine
This is Rietveld 408576698